git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH v2 1/8] completion: trivial test improvement

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 18, 2012, 10:56 UTC
Message-ID
<1353236213-13471-2-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1353236213-13471-1-git-send-email-felipe.contreras@gmail.com>

Instead of passing a dummy "", let's check if the last character is a space, and then move the _cword accordingly.

Apparently we were passing "" all the way to compgen, which fortunately expanded it to nothing.

Lets do the right thing though.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t9902-completion.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index 8fa025f..79a2453 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -50,6 +50,7 @@ run_completion ()
 	local -a COMPREPLY _words
 	local _cword
 	_words=( $1 )
+	test "${1: -1}" == ' ' && _words+=('')
 	(( _cword = ${#_words[@]} - 1 ))
 	__git_wrap__git_main && print_comp
 }
@@ -156,7 +157,7 @@ test_expect_success '__gitcomp - suffix' '
 '
 
 test_expect_success 'basic' '
-	run_completion "git \"\"" &&
+	run_completion "git " &&
 	# built-in
 	grep -q "^add \$" out &&
 	# script
-- 
1.8.0
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 9 in “completion: compgen/compadd cleanups”
  1. 0/8 completion: compgen/compadd cleanupsFelipe Contreras, Nov 18, 2012
  2. 1/8 completion: trivial test improvementFelipe Contreras, Nov 18, 2012
  3. 2/8 completion: get rid of empty COMPREPLY assignmentsFelipe Contreras, Nov 18, 2012
  4. 3/8 completion: add new __gitcompadd helperFelipe Contreras, Nov 18, 2012
  5. 4/8 tmp: completion: add SZEDER's testsFelipe Contreras, Nov 18, 2012
  6. 5/8 completion: get rid of compgenFelipe Contreras, Nov 18, 2012
  7. 6/8 tmp: completion: mark SZEDER's tests as fixedFelipe Contreras, Nov 18, 2012
  8. 7/8 completion: get rid of __gitcomp_1Felipe Contreras, Nov 18, 2012
  9. 8/8 completion: small optimizationFelipe Contreras, Nov 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.