git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH v2 0/8] completion: compgen/compadd cleanups

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 18, 2012, 10:56 UTC
Message-ID
<1353236213-13471-1-git-send-email-felipe.contreras@gmail.com>
Hi,

These were hinted by SZEDER, so I went ahead and implemented the changes trying to keep in mind the new zsh completion werapper. The resulting code should be more efficient, and a known breakage is fixed.

The first two patches are transplanted from another patch series which most likely is not going to use them.

I also borrowed the tests from another patch series from SZEDER, but they are not meant to be applied through this series.

SZEDER implemented some of this, but I prefer my version of the patches.
Felipe Contreras (8):
  completion: trivial test improvement
  completion: get rid of empty COMPREPLY assignments
  completion: add new __gitcompadd helper
  tmp: completion: add SZEDER's tests
  completion: get rid of compgen
  tmp: completion: mark SZEDER's tests as fixed
  completion: get rid of __gitcomp_1
  completion: small optimization
 contrib/completion/git-completion.bash | 77 ++++++++++++----------------------
 t/t9902-completion.sh                  | 66 ++++++++++++++++++++++++++++-
 2 files changed, 91 insertions(+), 52 deletions(-)
-- 
1.8.0
Next: Felipe Contreras
Message 1 of 9 in “completion: compgen/compadd cleanups”
  1. 0/8 completion: compgen/compadd cleanupsFelipe Contreras, Nov 18, 2012
  2. 1/8 completion: trivial test improvementFelipe Contreras, Nov 18, 2012
  3. 2/8 completion: get rid of empty COMPREPLY assignmentsFelipe Contreras, Nov 18, 2012
  4. 3/8 completion: add new __gitcompadd helperFelipe Contreras, Nov 18, 2012
  5. 4/8 tmp: completion: add SZEDER's testsFelipe Contreras, Nov 18, 2012
  6. 5/8 completion: get rid of compgenFelipe Contreras, Nov 18, 2012
  7. 6/8 tmp: completion: mark SZEDER's tests as fixedFelipe Contreras, Nov 18, 2012
  8. 7/8 completion: get rid of __gitcomp_1Felipe Contreras, Nov 18, 2012
  9. 8/8 completion: small optimizationFelipe Contreras, Nov 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.