[PATCH] fetch --all: pass --tags/--no-tags through to each remote
- From
Dan Johnson <computerdruid@gmail.com>
- Date
- Sep 1, 2012, 04:25 UTC
- Message-ID
- <1346473533-24175-1-git-send-email-ComputerDruid@gmail.com>
- In-Reply-To
- <7vr4qmn8va.fsf@alter.siamese.dyndns.org>
Reported-by: Oswald Buddenhagen <ossi@kde.org> Signed-off-by: Dan Johnson <ComputerDruid@gmail.com> ---
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
>Dan Johnson <computerdruid@gmail.com> writes: > >> I believe that is bad interaction with "--all" (probably a bug). If I >> am remembering correctly, --no-tags is internally a per-remote >> setting, so I'm guessing it's not getting set on all remotes here. >> >> I'll look into this more a bit later tonight. Does fetch --no-tags >> work when you specify a remote? > >Thanks.
And here it is. Apparently we just don't pass those options through. I didn't look to see if there are any other options we should consider passing through; it's quite possible there are. I also have not written a test to ensure that this doesn't break in the future. I will hopefully have time for these things tomorrow. It's getting too late for me to be able to put sentences together, so hopefully this mail comes out readable ;)
builtin/fetch.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/builtin/fetch.c b/builtin/fetch.c index bb9a074..c6bcbdc 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -857,6 +857,10 @@ static void add_options_to_argv(int *argc, const char **argv) argv[(*argc)++] = "--recurse-submodules"; else if (recurse_submodules == RECURSE_SUBMODULES_ON_DEMAND) argv[(*argc)++] = "--recurse-submodules=on-demand"; + if (tags == TAGS_SET) + argv[(*argc)++] = "--tags"; + else if (tags == TAGS_UNSET) + argv[(*argc)++] = "--no-tags"; if (verbosity >= 2) argv[(*argc)++] = "-v"; if (verbosity >= 1)
-- 1.7.11.1.59.gbc9e7dd.dirty