git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] gitweb: Get rid of unnecessary check of $signoff

From
Namhyung Kim <namhyung@kernel.org>
Date
Jul 3, 2012, 06:02 UTC
Message-ID
<1341295377-22083-2-git-send-email-namhyung@kernel.org>
In-Reply-To
<1341295377-22083-1-git-send-email-namhyung@kernel.org>

If $signoff set to 1, the $line would be handled in the if statement for the both cases. So the outer of the conditional always sees the $signoff always set to 0 and no need to check it. Thus we can finally get rid of it.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 gitweb/gitweb.perl |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 55e0e9e..7585e08 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4484,27 +4484,20 @@ sub git_print_log {
 	}
 
 	# print log
-	my $signoff = 0;
 	my $empty = 0;
 	foreach my $line (@$log) {
 		if ($line =~ m/^ *(signed[ \-]off[ \-]by[ :]|acked[ \-]by[ :]|cc[ :])/i) {
-			$signoff = 1;
 			$empty = 0;
 			if (! $opts{'-remove_signoff'}) {
 				print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
-				next;
-			} else {
-				# remove signoff lines
-				next;
 			}
-		} else {
-			$signoff = 0;
+			next;
 		}
 
 		# print only one empty line
 		# do not print empty line after signoff
 		if ($line eq "") {
-			next if ($empty || $signoff);
+			next if ($empty);
 			$empty = 1;
 		} else {
 			$empty = 0;
-- 
1.7.10.2
Previous: Namhyung KimNext: Junio C Hamano
Message 2 of 10 in “gitweb changes”
  1. 0/3 gitweb changesNamhyung Kim, Jul 3, 2012
  2. 1/3 gitweb: Get rid of unnecessary check of $signoffNamhyung Kim, Jul 3, 2012
  3. Junio C HamanoJul 3, 2012
  4. 2/3 gitweb: Handle a few other tags in git_print_logNamhyung Kim, Jul 3, 2012
  5. Junio C HamanoJul 3, 2012
  6. 3/3 gitweb: Add support to Link: tagNamhyung Kim, Jul 3, 2012
  7. Junio C HamanoJul 3, 2012
  8. Namhyung KimJul 4, 2012
  9. Namhyung KimJul 4, 2012
  10. Namhyung KimJul 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.