From: Namhyung Kim Date: Tue, 03 Jul 2012 06:02:55 GMT Subject: [PATCH 1/3] gitweb: Get rid of unnecessary check of $signoff Message-ID: <1341295377-22083-2-git-send-email-namhyung@kernel.org> In-Reply-To: <1341295377-22083-1-git-send-email-namhyung@kernel.org> If $signoff set to 1, the $line would be handled in the if statement for the both cases. So the outer of the conditional always sees the $signoff always set to 0 and no need to check it. Thus we can finally get rid of it. Signed-off-by: Namhyung Kim --- gitweb/gitweb.perl | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 55e0e9e..7585e08 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4484,27 +4484,20 @@ sub git_print_log { } # print log - my $signoff = 0; my $empty = 0; foreach my $line (@$log) { if ($line =~ m/^ *(signed[ \-]off[ \-]by[ :]|acked[ \-]by[ :]|cc[ :])/i) { - $signoff = 1; $empty = 0; if (! $opts{'-remove_signoff'}) { print "" . esc_html($line) . "
\n"; - next; - } else { - # remove signoff lines - next; } - } else { - $signoff = 0; + next; } # print only one empty line # do not print empty line after signoff if ($line eq "") { - next if ($empty || $signoff); + next if ($empty); $empty = 1; } else { $empty = 0; -- 1.7.10.2