git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] gitweb: Add support to Link: tag

From
Namhyung Kim <namhyung@kernel.org>
Date
Jul 3, 2012, 06:02 UTC
Message-ID
<1341295377-22083-4-git-send-email-namhyung@kernel.org>
In-Reply-To
<1341295377-22083-1-git-send-email-namhyung@kernel.org>

The tip tree is the one of major subsystem tree in the Linux kernel project. On the tip tree, the Link: tag is used for tracking the original discussion or context. Since it's ususally in the s-o-b area, it'd be better using same style with others.

Also as it tends to contain a message-id sent from git send-email, a part of the line which has more than 8 (hex-)digit characters would set a wrong hyperlink like [1]. Fix it by not using format_log_line_html().

[1] git.kernel.org/?p=linux/kernel/git/tip/tip.git;a=commit;h=08942f6d5d992e9486b07653fd87ea8182a22fa0
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 gitweb/gitweb.perl |    7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index e0701af..d07bcb7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4493,6 +4493,13 @@ sub git_print_log {
 				print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
 			}
 			next;
+		} elsif ($line =~ m,^ *link[ :](http://[\w/~.@%&=?+-]*),i) {
+			$empty = 0;
+			if (! $opts{'-remove_signoff'}) {
+				print "<span class=\"signoff\">Link: <a href=\"" . esc_html($1) . "\">" .
+					esc_html($1) . "</a></span><br/>\n";
+			}
+			next;
 		}
 
 		# print only one empty line
-- 
1.7.10.2
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 10 in “gitweb changes”
  1. 0/3 gitweb changesNamhyung Kim, Jul 3, 2012
  2. 1/3 gitweb: Get rid of unnecessary check of $signoffNamhyung Kim, Jul 3, 2012
  3. Junio C HamanoJul 3, 2012
  4. 2/3 gitweb: Handle a few other tags in git_print_logNamhyung Kim, Jul 3, 2012
  5. Junio C HamanoJul 3, 2012
  6. 3/3 gitweb: Add support to Link: tagNamhyung Kim, Jul 3, 2012
  7. Junio C HamanoJul 3, 2012
  8. Namhyung KimJul 4, 2012
  9. Namhyung KimJul 4, 2012
  10. Namhyung KimJul 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.