git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 03/23] Remove anachronism from comment

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Aug 4, 2011, 04:36 UTC
Message-ID
<1312432593-9841-4-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1312432593-9841-1-git-send-email-mhagger@alum.mit.edu>

Setting attributes to arbitrary values ("attribute=value") is now supported, so it is no longer necessary for this comment to justify prohibiting '=' in an attribute name.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 attr.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/attr.c b/attr.c
index f6b3f7e..4a1244f 100644
--- a/attr.c
+++ b/attr.c
@@ -50,10 +50,8 @@ static unsigned hash_name(const char *name, int namelen)
 static int invalid_attr_name(const char *name, int namelen)
 {
 	/*
-	 * Attribute name cannot begin with '-' and from
-	 * [-A-Za-z0-9_.].  We'd specifically exclude '=' for now,
-	 * as we might later want to allow non-binary value for
-	 * attributes, e.g. "*.svg	merge=special-merge-program-for-svg"
+	 * Attribute name cannot begin with '-' and must consist of
+	 * characters from [-A-Za-z0-9_.].
 	 */
 	if (*name == '-')
 		return -1;
-- 
1.7.6.8.gd2879
Previous: Michael HaggertyNext: Michael Haggerty
Message 4 of 24 in “Add --all option to git-check-attr”
  1. 00/23 Add --all option to git-check-attrMichael Haggerty, Aug 4, 2011
  2. 01/23 doc: Add a link from gitattributes(5) to git-check-attr(1)Michael Haggerty, Aug 4, 2011
  3. 02/23 doc: Correct git_attr() calls in example codeMichael Haggerty, Aug 4, 2011
  4. 03/23 Remove anachronism from commentMichael Haggerty, Aug 4, 2011
  5. 04/23 Disallow the empty string as an attribute nameMichael Haggerty, Aug 4, 2011
  6. 05/23 git-check-attr: Add missing "&&"Michael Haggerty, Aug 4, 2011
  7. 06/23 git-check-attr: Add tests of command-line parsingMichael Haggerty, Aug 4, 2011
  8. 07/23 Provide access to the name attribute of git_attrMichael Haggerty, Aug 4, 2011
  9. 08/23 git-check-attr: Use git_attr_name()Michael Haggerty, Aug 4, 2011
  10. 09/23 Teach prepare_attr_stack() to figure out dirlen itselfMichael Haggerty, Aug 4, 2011
  11. 10/23 Extract a function collect_all_attrs()Michael Haggerty, Aug 4, 2011
  12. 11/23 Remove redundant call to bootstrap_attr_stack()Michael Haggerty, Aug 4, 2011
  13. 12/23 Remove redundant checkMichael Haggerty, Aug 4, 2011
  14. 13/23 Allow querying all attributes on a fileMichael Haggerty, Aug 4, 2011
  15. 14/23 git-check-attr: Extract a function output_attr()Michael Haggerty, Aug 4, 2011
  16. 15/23 git-check-attr: Introduce a new variableMichael Haggerty, Aug 4, 2011
  17. 16/23 git-check-attr: Extract a function error_with_usage()Michael Haggerty, Aug 4, 2011
  18. 17/23 git-check-attr: Handle each error separatelyMichael Haggerty, Aug 4, 2011
  19. 18/23 git-check-attr: Process command-line args more systematicallyMichael Haggerty, Aug 4, 2011
  20. 19/23 git-check-attr: Error out if no pathnames are specifiedMichael Haggerty, Aug 4, 2011
  21. 20/23 git-check-attr: Add an --all option to show all attributesMichael Haggerty, Aug 4, 2011
  22. 21/23 git-check-attr: Drive two tests using the same raw dataMichael Haggerty, Aug 4, 2011
  23. 22/23 git-check-attr: Fix command-line handling to match docsMichael Haggerty, Aug 4, 2011
  24. 23/23 Rename git_checkattr() to git_check_attr()Michael Haggerty, Aug 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.