git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 15/23] git-check-attr: Introduce a new variable

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Aug 4, 2011, 04:36 UTC
Message-ID
<1312432593-9841-16-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1312432593-9841-1-git-send-email-mhagger@alum.mit.edu>

Avoid reusing variable "doubledash" to mean something other than the expected "position of a double-dash, if any".

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 builtin/check-attr.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/builtin/check-attr.c b/builtin/check-attr.c
index 384c5a6..c527078 100644
--- a/builtin/check-attr.c
+++ b/builtin/check-attr.c
@@ -71,7 +71,7 @@ static void check_attr_stdin_paths(int cnt, struct git_attr_check *check)
 int cmd_check_attr(int argc, const char **argv, const char *prefix)
 {
 	struct git_attr_check *check;
-	int cnt, i, doubledash;
+	int cnt, i, doubledash, filei;
 	const char *errstr = NULL;
 
 	argc = parse_options(argc, argv, prefix, check_attr_options,
@@ -92,14 +92,15 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
 	/* If there is no double dash, we handle only one attribute */
 	if (doubledash < 0) {
 		cnt = 1;
-		doubledash = 0;
-	} else
+		filei = 1;
+	} else {
 		cnt = doubledash;
-	doubledash++;
+		filei = doubledash + 1;
+	}
 
 	if (cnt <= 0)
 		errstr = "No attribute specified";
-	else if (stdin_paths && doubledash < argc)
+	else if (stdin_paths && filei < argc)
 		errstr = "Can't specify files with --stdin";
 	if (errstr) {
 		error("%s", errstr);
@@ -120,7 +121,7 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
 	if (stdin_paths)
 		check_attr_stdin_paths(cnt, check);
 	else {
-		for (i = doubledash; i < argc; i++)
+		for (i = filei; i < argc; i++)
 			check_attr(cnt, check, argv[i]);
 		maybe_flush_or_die(stdout, "attribute to stdout");
 	}
-- 
1.7.6.8.gd2879
Previous: Michael HaggertyNext: Michael Haggerty
Message 16 of 24 in “Add --all option to git-check-attr”
  1. 00/23 Add --all option to git-check-attrMichael Haggerty, Aug 4, 2011
  2. 01/23 doc: Add a link from gitattributes(5) to git-check-attr(1)Michael Haggerty, Aug 4, 2011
  3. 02/23 doc: Correct git_attr() calls in example codeMichael Haggerty, Aug 4, 2011
  4. 03/23 Remove anachronism from commentMichael Haggerty, Aug 4, 2011
  5. 04/23 Disallow the empty string as an attribute nameMichael Haggerty, Aug 4, 2011
  6. 05/23 git-check-attr: Add missing "&&"Michael Haggerty, Aug 4, 2011
  7. 06/23 git-check-attr: Add tests of command-line parsingMichael Haggerty, Aug 4, 2011
  8. 07/23 Provide access to the name attribute of git_attrMichael Haggerty, Aug 4, 2011
  9. 08/23 git-check-attr: Use git_attr_name()Michael Haggerty, Aug 4, 2011
  10. 09/23 Teach prepare_attr_stack() to figure out dirlen itselfMichael Haggerty, Aug 4, 2011
  11. 10/23 Extract a function collect_all_attrs()Michael Haggerty, Aug 4, 2011
  12. 11/23 Remove redundant call to bootstrap_attr_stack()Michael Haggerty, Aug 4, 2011
  13. 12/23 Remove redundant checkMichael Haggerty, Aug 4, 2011
  14. 13/23 Allow querying all attributes on a fileMichael Haggerty, Aug 4, 2011
  15. 14/23 git-check-attr: Extract a function output_attr()Michael Haggerty, Aug 4, 2011
  16. 15/23 git-check-attr: Introduce a new variableMichael Haggerty, Aug 4, 2011
  17. 16/23 git-check-attr: Extract a function error_with_usage()Michael Haggerty, Aug 4, 2011
  18. 17/23 git-check-attr: Handle each error separatelyMichael Haggerty, Aug 4, 2011
  19. 18/23 git-check-attr: Process command-line args more systematicallyMichael Haggerty, Aug 4, 2011
  20. 19/23 git-check-attr: Error out if no pathnames are specifiedMichael Haggerty, Aug 4, 2011
  21. 20/23 git-check-attr: Add an --all option to show all attributesMichael Haggerty, Aug 4, 2011
  22. 21/23 git-check-attr: Drive two tests using the same raw dataMichael Haggerty, Aug 4, 2011
  23. 22/23 git-check-attr: Fix command-line handling to match docsMichael Haggerty, Aug 4, 2011
  24. 23/23 Rename git_checkattr() to git_check_attr()Michael Haggerty, Aug 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.