git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 00/23] Add --all option to git-check-attr

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Aug 4, 2011, 04:36 UTC
Message-ID
<1312432593-9841-1-git-send-email-mhagger@alum.mit.edu>
This re-roll differs in the following ways from v2:
* The following series of refactoring patches were inserted:
      Teach prepare_attr_stack() to figure out dirlen itself
      Extract a function collect_all_attrs()
      Remove redundant call to bootstrap_attr_stack()
      Remove redundant check
  This change, in turn, simplifies patch
      Allow querying all attributes on a file
* The new API function is named git_all_attrs() instead of
  git_allattrs().
* Additionally, git_checkattr() is renamed to git_check_attr() at the
  suggestion of Junio.
* The renaming of struct git_attr_check to git_attr_value is no longer
  part of the patch series.

Thanks to Junio for the great feedback. I believe that I have addressed all of your comments.

Michael Haggerty (23):
  doc: Add a link from gitattributes(5) to git-check-attr(1)
  doc: Correct git_attr() calls in example code
  Remove anachronism from comment
  Disallow the empty string as an attribute name
  git-check-attr: Add missing "&&"
  git-check-attr: Add tests of command-line parsing
  Provide access to the name attribute of git_attr
  git-check-attr: Use git_attr_name()
  Teach prepare_attr_stack() to figure out dirlen itself
  Extract a function collect_all_attrs()
  Remove redundant call to bootstrap_attr_stack()
  Remove redundant check
  Allow querying all attributes on a file
  git-check-attr: Extract a function output_attr()
  git-check-attr: Introduce a new variable
  git-check-attr: Extract a function error_with_usage()
  git-check-attr: Handle each error separately
  git-check-attr: Process command-line args more systematically
  git-check-attr: Error out if no pathnames are specified
  git-check-attr: Add an --all option to show all attributes
  git-check-attr: Drive two tests using the same raw data
  git-check-attr: Fix command-line handling to match docs
  Rename git_checkattr() to git_check_attr()
 Documentation/git-check-attr.txt              |   23 ++++-
 Documentation/gitattributes.txt               |    3 +
 Documentation/technical/api-gitattributes.txt |   63 +++++++++-----
 archive.c                                     |    2 +-
 attr.c                                        |   79 ++++++++++++----
 attr.h                                        |   20 ++++-
 builtin/check-attr.c                          |  121 +++++++++++++++++--------
 builtin/pack-objects.c                        |    2 +-
 convert.c                                     |    2 +-
 ll-merge.c                                    |    4 +-
 t/t0003-attributes.sh                         |   61 +++++++++----
 userdiff.c                                    |    2 +-
 ws.c                                          |    2 +-
 13 files changed, 272 insertions(+), 112 deletions(-)
-- 
1.7.6.8.gd2879
Next: Michael Haggerty
Message 1 of 24 in “Add --all option to git-check-attr”
  1. 00/23 Add --all option to git-check-attrMichael Haggerty, Aug 4, 2011
  2. 01/23 doc: Add a link from gitattributes(5) to git-check-attr(1)Michael Haggerty, Aug 4, 2011
  3. 02/23 doc: Correct git_attr() calls in example codeMichael Haggerty, Aug 4, 2011
  4. 03/23 Remove anachronism from commentMichael Haggerty, Aug 4, 2011
  5. 04/23 Disallow the empty string as an attribute nameMichael Haggerty, Aug 4, 2011
  6. 05/23 git-check-attr: Add missing "&&"Michael Haggerty, Aug 4, 2011
  7. 06/23 git-check-attr: Add tests of command-line parsingMichael Haggerty, Aug 4, 2011
  8. 07/23 Provide access to the name attribute of git_attrMichael Haggerty, Aug 4, 2011
  9. 08/23 git-check-attr: Use git_attr_name()Michael Haggerty, Aug 4, 2011
  10. 09/23 Teach prepare_attr_stack() to figure out dirlen itselfMichael Haggerty, Aug 4, 2011
  11. 10/23 Extract a function collect_all_attrs()Michael Haggerty, Aug 4, 2011
  12. 11/23 Remove redundant call to bootstrap_attr_stack()Michael Haggerty, Aug 4, 2011
  13. 12/23 Remove redundant checkMichael Haggerty, Aug 4, 2011
  14. 13/23 Allow querying all attributes on a fileMichael Haggerty, Aug 4, 2011
  15. 14/23 git-check-attr: Extract a function output_attr()Michael Haggerty, Aug 4, 2011
  16. 15/23 git-check-attr: Introduce a new variableMichael Haggerty, Aug 4, 2011
  17. 16/23 git-check-attr: Extract a function error_with_usage()Michael Haggerty, Aug 4, 2011
  18. 17/23 git-check-attr: Handle each error separatelyMichael Haggerty, Aug 4, 2011
  19. 18/23 git-check-attr: Process command-line args more systematicallyMichael Haggerty, Aug 4, 2011
  20. 19/23 git-check-attr: Error out if no pathnames are specifiedMichael Haggerty, Aug 4, 2011
  21. 20/23 git-check-attr: Add an --all option to show all attributesMichael Haggerty, Aug 4, 2011
  22. 21/23 git-check-attr: Drive two tests using the same raw dataMichael Haggerty, Aug 4, 2011
  23. 22/23 git-check-attr: Fix command-line handling to match docsMichael Haggerty, Aug 4, 2011
  24. 23/23 Rename git_checkattr() to git_check_attr()Michael Haggerty, Aug 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.