git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 14/16] t7800 (difftool): add missing &&

From
Elijah Newren <newren@gmail.com>
Date
Sep 25, 2010, 19:07 UTC
Message-ID
<1285441627-28233-15-git-send-email-newren@gmail.com>
In-Reply-To
<1285441627-28233-1-git-send-email-newren@gmail.com>

Also remove a call to 'git config --unset difftool.prompt', since that is already unset by restore_test_defaults.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t7800-difftool.sh |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/t/t7800-difftool.sh b/t/t7800-difftool.sh
index 58dc6f6..ffb1960 100755
--- a/t/t7800-difftool.sh
+++ b/t/t7800-difftool.sh
@@ -98,7 +98,7 @@ test_expect_success PERL 'difftool --gui works without configured diff.guitool'
 
 # Specify the diff tool using $GIT_DIFF_TOOL
 test_expect_success PERL 'GIT_DIFF_TOOL variable' '
-	git config --unset diff.tool
+	git config --unset diff.tool &&
 	GIT_DIFF_TOOL=test-tool &&
 	export GIT_DIFF_TOOL &&
 
@@ -166,7 +166,6 @@ test_expect_success PERL 'difftool.prompt config variable is false' '
 
 # Test that we don't have to pass --no-prompt when mergetool.prompt is false
 test_expect_success PERL 'difftool merge.prompt = false' '
-	git config --unset difftool.prompt
 	git config mergetool.prompt false &&
 
 	diff=$(git difftool branch) &&
@@ -211,7 +210,7 @@ test_expect_success PERL 'difftool last flag wins' '
 # git-difftool falls back to git-mergetool config variables
 # so test that behavior here
 test_expect_success PERL 'difftool + mergetool config variables' '
-	remove_config_vars
+	remove_config_vars &&
 	git config merge.tool test-tool &&
 	git config mergetool.test-tool.cmd "cat \$LOCAL" &&
 
@@ -254,17 +253,17 @@ test_expect_success PERL 'difftool -x cat' '
 '
 
 test_expect_success PERL 'difftool --extcmd echo arg1' '
-	diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"echo\ \$1\" branch)
+	diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"echo\ \$1\" branch) &&
 	test "$diff" = file
 '
 
 test_expect_success PERL 'difftool --extcmd cat arg1' '
-	diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$1\" branch)
+	diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$1\" branch) &&
 	test "$diff" = master
 '
 
 test_expect_success PERL 'difftool --extcmd cat arg2' '
-	diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$2\" branch)
+	diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$2\" branch) &&
 	test "$diff" = branch
 '
 
-- 
1.7.3.95.g14291
Previous: Elijah NewrenNext: Elijah Newren
Message 18 of 24 in “[PATCHv3 00/16] Add missing &&'s in the testsuite”
  1. Elijah NewrenSep 25, 2010
  2. 01/16 t3020 (ls-files-error-unmatch): remove stray '1' from end of fileElijah Newren, Sep 25, 2010
  3. 02/16 t4017 (diff-retval): replace manual exit code check with test_expect_codeElijah Newren, Sep 25, 2010
  4. 03/16 t100[12] (read-tree-m-2way, read_tree_m_u_2way): add missing &&Elijah Newren, Sep 25, 2010
  5. 04/16 t4002 (diff-basic): use test_might_fail for commands that might failElijah Newren, Sep 25, 2010
  6. 05/16 t4202 (log): Replace '<git-command> || :' with test_might_failElijah Newren, Sep 25, 2010
  7. 06/16 t3600 (rm): add lots of missing &&Elijah Newren, Sep 25, 2010
  8. 07/16 t4019 (diff-wserror): add lots of missing &&Elijah Newren, Sep 25, 2010
  9. 08/16 t4026 (color): add missing &&Elijah Newren, Sep 25, 2010
  10. Jeff KingSep 26, 2010
  11. Elijah NewrenSep 26, 2010
  12. 09/16 t5602 (clone-remote-exec): add missing &&Elijah Newren, Sep 25, 2010
  13. 10/16 t6016 (rev-list-graph-simplify-history): add missing &&Elijah Newren, Sep 25, 2010
  14. 11/16 t6050 (replace): add missing &&Elijah Newren, Sep 25, 2010
  15. Christian CouderSep 26, 2010
  16. 12/16 t7001 (mv): add missing &&Elijah Newren, Sep 25, 2010
  17. 13/16 t7601 (merge-pull-config): add missing &&Elijah Newren, Sep 25, 2010
  18. 14/16 t7800 (difftool): add missing &&Elijah Newren, Sep 25, 2010
  19. 15/16 Add missing &&'s throughout the testsuiteElijah Newren, Sep 25, 2010
  20. Ævar Arnfjörð BjarmasonSep 25, 2010
  21. Elijah NewrenSep 25, 2010
  22. 16/16 Replace "unset VAR" with "unset VAR;" in testsuite as per t/READMEElijah Newren, Sep 25, 2010
  23. Ævar Arnfjörð BjarmasonSep 25, 2010
  24. Elijah NewrenSep 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.