git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 11/16] t6050 (replace): add missing &&

From
Elijah Newren <newren@gmail.com>
Date
Sep 25, 2010, 19:07 UTC
Message-ID
<1285441627-28233-12-git-send-email-newren@gmail.com>
In-Reply-To
<1285441627-28233-1-git-send-email-newren@gmail.com>

Also, mark the first grep in the 'fetch branch with replacement' test as being expected to fail.

CC: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
The modified test below was first introduced in 4e65b53 (t6050: check
pushing something based on a replaced commit 2009-05-27), with the
lack of chaining.  It is not clear reading the original or current
version of the test (before my change) whether the grep is meant to
fail, and thus whether my change is correct.  Hopefully Christian can
answer.
 t/t6050-replace.sh |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh
index c907523..11a0680 100755
--- a/t/t6050-replace.sh
+++ b/t/t6050-replace.sh
@@ -205,8 +205,9 @@ test_expect_success 'fetch branch with replacement' '
      git branch tofetch $HASH6 &&
      (
 	  cd clone_dir &&
-	  git fetch origin refs/heads/tofetch:refs/heads/parallel3
-	  git log --pretty=oneline parallel3 | grep $PARA3
+	  git fetch origin refs/heads/tofetch:refs/heads/parallel3 &&
+	  git log --pretty=oneline parallel3 >output &&
+	  ! grep $PARA3 output &&
 	  git show $PARA3 | grep "A U Thor"
      )
 '
-- 
1.7.3.95.g14291
Previous: Elijah NewrenNext: Christian Couder
Message 14 of 24 in “[PATCHv3 00/16] Add missing &&'s in the testsuite”
  1. Elijah NewrenSep 25, 2010
  2. 01/16 t3020 (ls-files-error-unmatch): remove stray '1' from end of fileElijah Newren, Sep 25, 2010
  3. 02/16 t4017 (diff-retval): replace manual exit code check with test_expect_codeElijah Newren, Sep 25, 2010
  4. 03/16 t100[12] (read-tree-m-2way, read_tree_m_u_2way): add missing &&Elijah Newren, Sep 25, 2010
  5. 04/16 t4002 (diff-basic): use test_might_fail for commands that might failElijah Newren, Sep 25, 2010
  6. 05/16 t4202 (log): Replace '<git-command> || :' with test_might_failElijah Newren, Sep 25, 2010
  7. 06/16 t3600 (rm): add lots of missing &&Elijah Newren, Sep 25, 2010
  8. 07/16 t4019 (diff-wserror): add lots of missing &&Elijah Newren, Sep 25, 2010
  9. 08/16 t4026 (color): add missing &&Elijah Newren, Sep 25, 2010
  10. Jeff KingSep 26, 2010
  11. Elijah NewrenSep 26, 2010
  12. 09/16 t5602 (clone-remote-exec): add missing &&Elijah Newren, Sep 25, 2010
  13. 10/16 t6016 (rev-list-graph-simplify-history): add missing &&Elijah Newren, Sep 25, 2010
  14. 11/16 t6050 (replace): add missing &&Elijah Newren, Sep 25, 2010
  15. Christian CouderSep 26, 2010
  16. 12/16 t7001 (mv): add missing &&Elijah Newren, Sep 25, 2010
  17. 13/16 t7601 (merge-pull-config): add missing &&Elijah Newren, Sep 25, 2010
  18. 14/16 t7800 (difftool): add missing &&Elijah Newren, Sep 25, 2010
  19. 15/16 Add missing &&'s throughout the testsuiteElijah Newren, Sep 25, 2010
  20. Ævar Arnfjörð BjarmasonSep 25, 2010
  21. Elijah NewrenSep 25, 2010
  22. 16/16 Replace "unset VAR" with "unset VAR;" in testsuite as per t/READMEElijah Newren, Sep 25, 2010
  23. Ævar Arnfjörð BjarmasonSep 25, 2010
  24. Elijah NewrenSep 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.