git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 10/16] t6016 (rev-list-graph-simplify-history): add missing &&

From
Elijah Newren <newren@gmail.com>
Date
Sep 25, 2010, 19:07 UTC
Message-ID
<1285441627-28233-11-git-send-email-newren@gmail.com>
In-Reply-To
<1285441627-28233-1-git-send-email-newren@gmail.com>

Also removed several repeated tag and branch deletions, since the tags and branches had already been deleted.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t6016-rev-list-graph-simplify-history.sh |   24 ++++++------------------
 1 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/t/t6016-rev-list-graph-simplify-history.sh b/t/t6016-rev-list-graph-simplify-history.sh
index 27fd52b..e640c41 100755
--- a/t/t6016-rev-list-graph-simplify-history.sh
+++ b/t/t6016-rev-list-graph-simplify-history.sh
@@ -29,7 +29,7 @@ test_expect_success 'set up rev-list --graph test' '
 	# Octopus merge B and C into branch A
 	git checkout A &&
 	git merge B C &&
-	git tag A4
+	git tag A4 &&
 
 	test_commit A5 bar.txt &&
 
@@ -39,7 +39,7 @@ test_expect_success 'set up rev-list --graph test' '
 	test_commit C4 bar.txt &&
 	git checkout A &&
 	git merge -s ours C &&
-	git tag A6
+	git tag A6 &&
 
 	test_commit A7 bar.txt &&
 
@@ -90,7 +90,7 @@ test_expect_success '--graph --all' '
 # that undecorated merges are interesting, even with --simplify-by-decoration
 test_expect_success '--graph --simplify-by-decoration' '
 	rm -f expected &&
-	git tag -d A4
+	git tag -d A4 &&
 	echo "* $A7" >> expected &&
 	echo "*   $A6" >> expected &&
 	echo "|\\  " >> expected &&
@@ -119,9 +119,9 @@ test_expect_success '--graph --simplify-by-decoration' '
 # Get rid of all decorations on branch B, and graph with it simplified away
 test_expect_success '--graph --simplify-by-decoration prune branch B' '
 	rm -f expected &&
-	git tag -d B2
-	git tag -d B1
-	git branch -d B
+	git tag -d B2 &&
+	git tag -d B1 &&
+	git branch -d B &&
 	echo "* $A7" >> expected &&
 	echo "*   $A6" >> expected &&
 	echo "|\\  " >> expected &&
@@ -143,9 +143,6 @@ test_expect_success '--graph --simplify-by-decoration prune branch B' '
 
 test_expect_success '--graph --full-history -- bar.txt' '
 	rm -f expected &&
-	git tag -d B2
-	git tag -d B1
-	git branch -d B
 	echo "* $A7" >> expected &&
 	echo "*   $A6" >> expected &&
 	echo "|\\  " >> expected &&
@@ -163,9 +160,6 @@ test_expect_success '--graph --full-history -- bar.txt' '
 
 test_expect_success '--graph --full-history --simplify-merges -- bar.txt' '
 	rm -f expected &&
-	git tag -d B2
-	git tag -d B1
-	git branch -d B
 	echo "* $A7" >> expected &&
 	echo "*   $A6" >> expected &&
 	echo "|\\  " >> expected &&
@@ -181,9 +175,6 @@ test_expect_success '--graph --full-history --simplify-merges -- bar.txt' '
 
 test_expect_success '--graph -- bar.txt' '
 	rm -f expected &&
-	git tag -d B2
-	git tag -d B1
-	git branch -d B
 	echo "* $A7" >> expected &&
 	echo "* $A5" >> expected &&
 	echo "* $A3" >> expected &&
@@ -196,9 +187,6 @@ test_expect_success '--graph -- bar.txt' '
 
 test_expect_success '--graph --sparse -- bar.txt' '
 	rm -f expected &&
-	git tag -d B2
-	git tag -d B1
-	git branch -d B
 	echo "* $A7" >> expected &&
 	echo "* $A6" >> expected &&
 	echo "* $A5" >> expected &&
-- 
1.7.3.95.g14291
Previous: Elijah NewrenNext: Elijah Newren
Message 13 of 24 in “[PATCHv3 00/16] Add missing &&'s in the testsuite”
  1. Elijah NewrenSep 25, 2010
  2. 01/16 t3020 (ls-files-error-unmatch): remove stray '1' from end of fileElijah Newren, Sep 25, 2010
  3. 02/16 t4017 (diff-retval): replace manual exit code check with test_expect_codeElijah Newren, Sep 25, 2010
  4. 03/16 t100[12] (read-tree-m-2way, read_tree_m_u_2way): add missing &&Elijah Newren, Sep 25, 2010
  5. 04/16 t4002 (diff-basic): use test_might_fail for commands that might failElijah Newren, Sep 25, 2010
  6. 05/16 t4202 (log): Replace '<git-command> || :' with test_might_failElijah Newren, Sep 25, 2010
  7. 06/16 t3600 (rm): add lots of missing &&Elijah Newren, Sep 25, 2010
  8. 07/16 t4019 (diff-wserror): add lots of missing &&Elijah Newren, Sep 25, 2010
  9. 08/16 t4026 (color): add missing &&Elijah Newren, Sep 25, 2010
  10. Jeff KingSep 26, 2010
  11. Elijah NewrenSep 26, 2010
  12. 09/16 t5602 (clone-remote-exec): add missing &&Elijah Newren, Sep 25, 2010
  13. 10/16 t6016 (rev-list-graph-simplify-history): add missing &&Elijah Newren, Sep 25, 2010
  14. 11/16 t6050 (replace): add missing &&Elijah Newren, Sep 25, 2010
  15. Christian CouderSep 26, 2010
  16. 12/16 t7001 (mv): add missing &&Elijah Newren, Sep 25, 2010
  17. 13/16 t7601 (merge-pull-config): add missing &&Elijah Newren, Sep 25, 2010
  18. 14/16 t7800 (difftool): add missing &&Elijah Newren, Sep 25, 2010
  19. 15/16 Add missing &&'s throughout the testsuiteElijah Newren, Sep 25, 2010
  20. Ævar Arnfjörð BjarmasonSep 25, 2010
  21. Elijah NewrenSep 25, 2010
  22. 16/16 Replace "unset VAR" with "unset VAR;" in testsuite as per t/READMEElijah Newren, Sep 25, 2010
  23. Ævar Arnfjörð BjarmasonSep 25, 2010
  24. Elijah NewrenSep 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.