Re: [PATCH V3] git-send-email.perl: Add --to-cmd
On Fri, 2010-09-24 at 08:32 -0700, Jakub Narebski wrote:
Show 6 quoted lines
> Joe Perches <joe@perches.com> writes:
> > +# Execute a command (ie: $to_cmd) to get a list of email addresses
> > +# and return a results array
> > +sub recipients_cmd(@) {
> Do not use subroutine prototypes: they do not do what you think they
> do. In this case using prototype is unnecessary and can be dangerous.
It can be removed. I was following the form of the
other returned array in the code.
sub unique_email_list(@) {Show 5 quoted lines
> > + while(<F>) {
> > + my $address = $_;
> > + $address =~ s/^\s*//g;
> > + $address =~ s/\n$//g;
> Hmmm... why does it remove leading, but not trailing whitespace?
Unmodified from the current. I agree it should do both.
Joe Perches <joe@perches.com>