From: Joe Perches <joe@perches.com>
Date: Fri, 24 Sep 2010 16:06:34 GMT
Subject: Re: [PATCH V3] git-send-email.perl: Add --to-cmd
Message-ID: <1285344394.11616.23.camel@Joe-Laptop>
In-Reply-To: <m3lj6rgnub.fsf@localhost.localdomain>

On Fri, 2010-09-24 at 08:32 -0700, Jakub Narebski wrote:
> Joe Perches <joe@perches.com> writes:
> > +# Execute a command (ie: $to_cmd) to get a list of email addresses
> > +# and return a results array
> > +sub recipients_cmd(@) {
> Do not use subroutine prototypes: they do not do what you think they
> do.  In this case using prototype is unnecessary and can be dangerous.
 
It can be removed.  I was following the form of the
other returned array in the code.

sub unique_email_list(@) {

> > +	while(<F>) {
> > +		my $address = $_;
> > +		$address =~ s/^\s*//g;
> > +		$address =~ s/\n$//g;
> Hmmm... why does it remove leading, but not trailing whitespace?
 
Unmodified from the current.  I agree it should do both.