[PATCHv2 5/8] tree_entry_interesting(): Make return value more specific
- From
Elijah Newren <newren@gmail.com>
- Date
- Aug 26, 2010, 06:21 UTC
- Message-ID
- <1282803711-10253-6-git-send-email-newren@gmail.com>
- In-Reply-To
- <1282803711-10253-1-git-send-email-newren@gmail.com>
tree_entry_interesting() can signal to its callers not only if the given entry matches one of the specified paths, but whether all remaining paths will (or will not) match. When no paths are specified, all paths are considered interesting, so intead of returning 1 (this path is interesting) return 2 (all paths are interesting).
This will allow the caller to avoid calling tree_entry_interesting() again, which theoretically should speed up tree walking. I am not able to measure any actual gains in practice, but it certainly can not hurt and seems to make the code more readable to me.
Signed-off-by: Elijah Newren <newren@gmail.com> --- tree-diff.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tree-diff.c b/tree-diff.c index 75b1480..bac5008 100644 --- a/tree-diff.c +++ b/tree-diff.c @@ -103,7 +103,7 @@ int tree_entry_interesting(struct tree_desc *desc, const char *base, int baselen int never_interesting = -1; if (!opt->nr_paths) - return 1; + return 2; sha1 = tree_entry_extract(desc, &path, &mode);
-- 1.7.2.2.45.ga60f