git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 3/8] Document pre-condition for tree_entry_interesting

From
Elijah Newren <newren@gmail.com>
Date
Aug 26, 2010, 06:21 UTC
Message-ID
<1282803711-10253-4-git-send-email-newren@gmail.com>
In-Reply-To
<1282803711-10253-1-git-send-email-newren@gmail.com>

tree_entry_interesting will fail to find appropriate matches if the base directory path is not terminated with a slash. Knowing this earlier would have saved me some debugging time.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 tree-diff.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tree-diff.c b/tree-diff.c
index 2fb670b..75b1480 100644
--- a/tree-diff.c
+++ b/tree-diff.c
@@ -85,6 +85,8 @@ static int compare_tree_entry(struct tree_desc *t1, struct tree_desc *t2, const
 /*
  * Is a tree entry interesting given the pathspec we have?
  *
+ * Pre-condition: baselen == 0 || base[baselen-1] == '/'
+ *
  * Return:
  *  - 2 for "yes, and all subsequent entries will be"
  *  - 1 for yes
-- 
1.7.2.2.45.ga60f
Previous: Elijah NewrenNext: Elijah Newren
Message 4 of 10 in “[PATCHv2 0/8] Make rev-list --objects work with pathspecs; minor optimizations”
  1. Elijah NewrenAug 26, 2010
  2. 1/8 Add testcases showing how pathspecs are ignored with rev-list --objectsElijah Newren, Aug 26, 2010
  3. 2/8 Make rev-list --objects work together with pathspecsElijah Newren, Aug 26, 2010
  4. 3/8 Document pre-condition for tree_entry_interestingElijah Newren, Aug 26, 2010
  5. 4/8 tree-walk: Correct bitrotted comment about tree_entry()Elijah Newren, Aug 26, 2010
  6. 5/8 tree_entry_interesting(): Make return value more specificElijah Newren, Aug 26, 2010
  7. 6/8 diff_tree(): Skip skip_uninteresting() when all remaining paths interestingElijah Newren, Aug 26, 2010
  8. 7/8 list-objects.c: Avoid recomputing interesting-ness for subtrees when possibleElijah Newren, Aug 26, 2010
  9. 8/8 tree-diff.c: Avoid recomputing interesting-ness for subtrees when possibleElijah Newren, Aug 26, 2010
  10. Junio C HamanoAug 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.