git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 4/8] tree-walk: Correct bitrotted comment about tree_entry()

From
Elijah Newren <newren@gmail.com>
Date
Aug 26, 2010, 06:21 UTC
Message-ID
<1282803711-10253-5-git-send-email-newren@gmail.com>
In-Reply-To
<1282803711-10253-1-git-send-email-newren@gmail.com>

There was a code comment that referred to the "above two functions" but over time the functions immediately preceding the comment have changed. Just mention the relevant functions by name.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 tree-walk.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tree-walk.h b/tree-walk.h
index 42110a4..a5175fa 100644
--- a/tree-walk.h
+++ b/tree-walk.h
@@ -28,7 +28,9 @@ static inline int tree_entry_len(const char *name, const unsigned char *sha1)
 void update_tree_entry(struct tree_desc *);
 void init_tree_desc(struct tree_desc *desc, const void *buf, unsigned long size);
 
-/* Helper function that does both of the above and returns true for success */
+/* Helper function that does both tree_entry_extract() and update_tree_entry()
+ * and returns true for success
+ */
 int tree_entry(struct tree_desc *, struct name_entry *);
 
 void *fill_tree_descriptor(struct tree_desc *desc, const unsigned char *sha1);
-- 
1.7.2.2.45.ga60f
Previous: Elijah NewrenNext: Elijah Newren
Message 5 of 10 in “[PATCHv2 0/8] Make rev-list --objects work with pathspecs; minor optimizations”
  1. Elijah NewrenAug 26, 2010
  2. 1/8 Add testcases showing how pathspecs are ignored with rev-list --objectsElijah Newren, Aug 26, 2010
  3. 2/8 Make rev-list --objects work together with pathspecsElijah Newren, Aug 26, 2010
  4. 3/8 Document pre-condition for tree_entry_interestingElijah Newren, Aug 26, 2010
  5. 4/8 tree-walk: Correct bitrotted comment about tree_entry()Elijah Newren, Aug 26, 2010
  6. 5/8 tree_entry_interesting(): Make return value more specificElijah Newren, Aug 26, 2010
  7. 6/8 diff_tree(): Skip skip_uninteresting() when all remaining paths interestingElijah Newren, Aug 26, 2010
  8. 7/8 list-objects.c: Avoid recomputing interesting-ness for subtrees when possibleElijah Newren, Aug 26, 2010
  9. 8/8 tree-diff.c: Avoid recomputing interesting-ness for subtrees when possibleElijah Newren, Aug 26, 2010
  10. Junio C HamanoAug 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.