git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH JGit 07/19] implemented the packs file update functionality

From
mr.gaffo@gmail.com <mr.gaffo@gmail.com>
Date
Sep 13, 2009, 18:44 UTC
Message-ID
<1252867475-858-8-git-send-email-mr.gaffo@gmail.com>
In-Reply-To
<1252867475-858-7-git-send-email-mr.gaffo@gmail.com>
From: mike.gaffney <mike.gaffney@asolutions.com>
---
 .../jgit/lib/UpdateDirectoryInfoCacheTest.java     |   23 ++++++++++++++++++-
 .../spearce/jgit/lib/UpdateDirectoryInfoCache.java |   17 +++++++++-----
 2 files changed, 32 insertions(+), 8 deletions(-)
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/UpdateDirectoryInfoCacheTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/UpdateDirectoryInfoCacheTest.java
index 11d183e..25b78c5 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/UpdateDirectoryInfoCacheTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/UpdateDirectoryInfoCacheTest.java
@@ -1,11 +1,30 @@
 package org.spearce.jgit.lib;
 
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+
 import junit.framework.TestCase;
 
+import org.spearce.jgit.util.JGitTestUtil;
+
 public class UpdateDirectoryInfoCacheTest extends TestCase {
+	private static final String PACK_NAME = "pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f";
+	private static final File TEST_PACK = JGitTestUtil.getTestResourceFile(PACK_NAME + ".pack");
+	private static final File TEST_IDX = JGitTestUtil.getTestResourceFile(PACK_NAME + ".idx");
 	
-	public void testBase() throws Exception {
-		fail("nyi");
+	public void testCreatesTheFileAndPutsTheContentsIn() throws Exception {
+		List<PackFile> packs = new ArrayList<PackFile>();
+		packs.add(new PackFile(TEST_IDX, TEST_PACK));
+		
+		File packsFile = File.createTempFile(UpdateDirectoryInfoCacheTest.class.getSimpleName(), "tstdata");
+		packsFile.deleteOnExit();
+		
+		String expectedContents = new PacksFileContentsCreator(packs).toString();
+		
+		new UpdateDirectoryInfoCache(packs, packsFile).execute();
+		
+		assertEquals(expectedContents, JGitTestUtil.readFileAsString(packsFile));
 	}
 
 }
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/UpdateDirectoryInfoCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/UpdateDirectoryInfoCache.java
index 2bceb9e..72a315a 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/UpdateDirectoryInfoCache.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/UpdateDirectoryInfoCache.java
@@ -1,22 +1,27 @@
 package org.spearce.jgit.lib;
 
+import java.io.BufferedWriter;
 import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
 import java.util.List;
 
 public class UpdateDirectoryInfoCache {
 
 	private List<PackFile> packsList;
-	private File infoDirectory;
+	private File infoPacksFile;
 
 	public UpdateDirectoryInfoCache(List<PackFile> packsList,
-			File infoDirectory) {
+									File infoPacksFile) {
 		this.packsList = packsList;
-		this.infoDirectory = infoDirectory;
+		this.infoPacksFile = infoPacksFile;
 	}
 
-	public void execute() {
-//		File objectFile = objectDatabase.
-//		String packsContents = new PacksFileContentsCreator(this.objectDatabase.listLocalPacks()).toString();
+	public void execute() throws IOException {
+		String packsContents = new PacksFileContentsCreator(packsList).toString();
+		FileOutputStream fos = new FileOutputStream(infoPacksFile);
+		fos.write(packsContents.getBytes());
+		fos.close();
 	}
 
 }
-- 
1.6.4.2
Previous: mr.gaffo@gmail.comNext: mr.gaffo@gmail.com
Message 8 of 25 in “Adding update-server-info functionality”
  1. Adding update-server-info functionalitymr.gaffo@gmail.com, Sep 13, 2009
  2. 01/19 adding tests for ObjectDirectorymr.gaffo@gmail.com, Sep 13, 2009
  3. 02/19 Create abstract method on ObjectDatabase for accessing the list of local pack files.mr.gaffo@gmail.com, Sep 13, 2009
  4. 03/19 Add abstract method for updating the object db's info cache Implemented passthrough on Alternate for the update of infocachemr.gaffo@gmail.com, Sep 13, 2009
  5. 04/19 added utility that generates the contents of the objects/info/packs file as a string from a list of PackFilesmr.gaffo@gmail.com, Sep 13, 2009
  6. 05/19 Made tests for listLocalPacks function on ObjectDirectory and made them passmr.gaffo@gmail.com, Sep 13, 2009
  7. 06/19 added utility for reading the contents of a file as a stringmr.gaffo@gmail.com, Sep 13, 2009
  8. 07/19 implemented the packs file update functionalitymr.gaffo@gmail.com, Sep 13, 2009
  9. 08/19 changed signature to allow a IOExceptionmr.gaffo@gmail.com, Sep 13, 2009
  10. 09/19 Didn't like the old name, this is more specific to it just updating the packs info cachemr.gaffo@gmail.com, Sep 13, 2009
  11. 10/19 moved test up to a higher level to test actual functionalitymr.gaffo@gmail.com, Sep 13, 2009
  12. 11/19 removed unused importmr.gaffo@gmail.com, Sep 13, 2009
  13. 12/19 moved info/packs into a constantmr.gaffo@gmail.com, Sep 13, 2009
  14. 13/19 made the call update the object database's info cachemr.gaffo@gmail.com, Sep 13, 2009
  15. 14/19 pulled out some helper functions that will be useful for other testsmr.gaffo@gmail.com, Sep 13, 2009
  16. 15/19 Adding in a InfoDatabase like ObjectDatabase and and implementation based upon a directory.mr.gaffo@gmail.com, Sep 13, 2009
  17. 16/19 added tests for the file based info cache update and made passmr.gaffo@gmail.com, Sep 13, 2009
  18. 17/19 added call to update the info refs filemr.gaffo@gmail.com, Sep 13, 2009
  19. 18/19 Added Copyright Noticesmr.gaffo@gmail.com, Sep 13, 2009
  20. 19/19 changed \r to \n per compliance with real gitmr.gaffo@gmail.com, Sep 13, 2009
  21. Robin RosenbergSep 15, 2009
  22. Robin RosenbergSep 15, 2009
  23. Robin RosenbergSep 15, 2009
  24. Robin RosenbergSep 15, 2009
  25. Robin RosenbergSep 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.