git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH JGit 16/19] added tests for the file based info cache update and made pass

From
mr.gaffo@gmail.com <mr.gaffo@gmail.com>
Date
Sep 13, 2009, 18:44 UTC
Message-ID
<1252867475-858-17-git-send-email-mr.gaffo@gmail.com>
In-Reply-To
<1252867475-858-16-git-send-email-mr.gaffo@gmail.com>
From: mike.gaffney <mike.gaffney@asolutions.com>
---
 .../jgit/lib/InfoDirectoryDatabaseTest.java        |   30 ++++++++++++++++++++
 .../src/org/spearce/jgit/lib/InfoDatabase.java     |   15 ++++++++++
 .../spearce/jgit/lib/InfoDirectoryDatabase.java    |   15 ++++++++++
 3 files changed, 60 insertions(+), 0 deletions(-)
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/InfoDirectoryDatabaseTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/InfoDirectoryDatabaseTest.java
index 2b7fb5b..22972fa 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/InfoDirectoryDatabaseTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/InfoDirectoryDatabaseTest.java
@@ -1,6 +1,10 @@
 package org.spearce.jgit.lib;
 
 import java.io.File;
+import java.io.IOException;
+import java.io.StringWriter;
+import java.util.ArrayList;
+import java.util.Collection;
 
 import org.spearce.jgit.util.JGitTestUtil;
 
@@ -27,4 +31,30 @@ public void testCreateCreatesDirectory() throws Exception {
 		new InfoDirectoryDatabase(testDir).create();
 		assertTrue(testDir.exists());
 	}
+	
+	public void testUpdateInfoCache() throws Exception {
+		Collection<Ref> refs = new ArrayList<Ref>();
+		refs.add(new Ref(Ref.Storage.LOOSE, "refs/heads/master", ObjectId.fromString("32aae7aef7a412d62192f710f2130302997ec883")));
+		refs.add(new Ref(Ref.Storage.LOOSE, "refs/heads/development", ObjectId.fromString("184063c9b594f8968d61a686b2f6052779551613")));
+
+		File expectedFile = new File(testDir, "refs");
+		assertFalse(expectedFile.exists());
+		
+		
+		final StringWriter expectedString = new StringWriter();
+		new RefWriter(refs) {
+			@Override
+			protected void writeFile(String file, byte[] content) throws IOException {
+				expectedString.write(new String(content));
+			}
+		}.writeInfoRefs();
+		
+		InfoDirectoryDatabase out = new InfoDirectoryDatabase(testDir);
+		out.create();
+		out.updateInfoCache(refs);
+		assertTrue(expectedFile.exists());
+		
+		String actual = JGitTestUtil.readFileAsString(expectedFile);
+		assertEquals(expectedString.toString(), actual);
+	}
 }
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDatabase.java
index 2f1f398..26f8f22 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDatabase.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDatabase.java
@@ -1,8 +1,23 @@
 package org.spearce.jgit.lib;
 
+import java.io.IOException;
+import java.util.Collection;
+
 public abstract class InfoDatabase {
 
+	/**
+	 * Create the info database
+	 */
 	public void create() {
 	}
 
+	/**
+	 * Updates the info cache typically done by update-server-info command.
+	 * This writes THIS repository's refs out to the info/refs file.
+	 * @param collection the collections of refs to update the info cache with
+	 * @throws IOException for any type of failure on the local or remote 
+	 * 					   data store
+	 */
+	public abstract void updateInfoCache(Collection<Ref> collection) throws IOException;
+
 }
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDirectoryDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDirectoryDatabase.java
index 20d8a70..f95be2f 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDirectoryDatabase.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/InfoDirectoryDatabase.java
@@ -1,6 +1,9 @@
 package org.spearce.jgit.lib;
 
 import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.util.Collection;
 
 public class InfoDirectoryDatabase extends InfoDatabase {
 
@@ -15,4 +18,16 @@ public void create() {
 		info.mkdirs();
 	}
 
+	@Override
+	public void updateInfoCache(Collection<Ref> refs) throws IOException {
+		new RefWriter(refs) {
+			@Override
+			protected void writeFile(String file, byte[] content) throws IOException {
+				FileOutputStream fos = new FileOutputStream(new File(info, "refs"));
+				fos.write(content);
+				fos.close();
+			}
+		}.writeInfoRefs();
+	}
+
 }
-- 
1.6.4.2
Previous: mr.gaffo@gmail.comNext: mr.gaffo@gmail.com
Message 17 of 25 in “Adding update-server-info functionality”
  1. Adding update-server-info functionalitymr.gaffo@gmail.com, Sep 13, 2009
  2. 01/19 adding tests for ObjectDirectorymr.gaffo@gmail.com, Sep 13, 2009
  3. 02/19 Create abstract method on ObjectDatabase for accessing the list of local pack files.mr.gaffo@gmail.com, Sep 13, 2009
  4. 03/19 Add abstract method for updating the object db's info cache Implemented passthrough on Alternate for the update of infocachemr.gaffo@gmail.com, Sep 13, 2009
  5. 04/19 added utility that generates the contents of the objects/info/packs file as a string from a list of PackFilesmr.gaffo@gmail.com, Sep 13, 2009
  6. 05/19 Made tests for listLocalPacks function on ObjectDirectory and made them passmr.gaffo@gmail.com, Sep 13, 2009
  7. 06/19 added utility for reading the contents of a file as a stringmr.gaffo@gmail.com, Sep 13, 2009
  8. 07/19 implemented the packs file update functionalitymr.gaffo@gmail.com, Sep 13, 2009
  9. 08/19 changed signature to allow a IOExceptionmr.gaffo@gmail.com, Sep 13, 2009
  10. 09/19 Didn't like the old name, this is more specific to it just updating the packs info cachemr.gaffo@gmail.com, Sep 13, 2009
  11. 10/19 moved test up to a higher level to test actual functionalitymr.gaffo@gmail.com, Sep 13, 2009
  12. 11/19 removed unused importmr.gaffo@gmail.com, Sep 13, 2009
  13. 12/19 moved info/packs into a constantmr.gaffo@gmail.com, Sep 13, 2009
  14. 13/19 made the call update the object database's info cachemr.gaffo@gmail.com, Sep 13, 2009
  15. 14/19 pulled out some helper functions that will be useful for other testsmr.gaffo@gmail.com, Sep 13, 2009
  16. 15/19 Adding in a InfoDatabase like ObjectDatabase and and implementation based upon a directory.mr.gaffo@gmail.com, Sep 13, 2009
  17. 16/19 added tests for the file based info cache update and made passmr.gaffo@gmail.com, Sep 13, 2009
  18. 17/19 added call to update the info refs filemr.gaffo@gmail.com, Sep 13, 2009
  19. 18/19 Added Copyright Noticesmr.gaffo@gmail.com, Sep 13, 2009
  20. 19/19 changed \r to \n per compliance with real gitmr.gaffo@gmail.com, Sep 13, 2009
  21. Robin RosenbergSep 15, 2009
  22. Robin RosenbergSep 15, 2009
  23. Robin RosenbergSep 15, 2009
  24. Robin RosenbergSep 15, 2009
  25. Robin RosenbergSep 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.