git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 7/7] FindBugs: Disable clone() idiom tests

From
Shawn O. Pearce <spearce@spearce.org>
Date
May 4, 2009, 23:30 UTC
Message-ID
<1241479848-20687-7-git-send-email-spearce@spearce.org>
In-Reply-To
<1241479848-20687-6-git-send-email-spearce@spearce.org>

We tend not to implement Cloneable, but instead define our own form of clone() on objects that we want to permit making clones of. This is because Cloneable is a rather poor interface in the JVM with its implicit field copying, but the method name is the right name for us.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 org.spearce.jgit/.fbprefs |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/org.spearce.jgit/.fbprefs b/org.spearce.jgit/.fbprefs
index d6f94c3..81a0767 100644
--- a/org.spearce.jgit/.fbprefs
+++ b/org.spearce.jgit/.fbprefs
@@ -1,5 +1,5 @@
 #FindBugs User Preferences
-#Mon May 04 20:17:32 CEST 2009
+#Mon May 04 16:24:13 PDT 2009
 detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true
 detectorBadAppletConstructor=BadAppletConstructor|false
 detectorBadResultSetAccess=BadResultSetAccess|true
@@ -10,7 +10,7 @@ detectorBooleanReturnNull=BooleanReturnNull|true
 detectorCallToUnsupportedMethod=CallToUnsupportedMethod|true
 detectorCheckImmutableAnnotation=CheckImmutableAnnotation|true
 detectorCheckTypeQualifiers=CheckTypeQualifiers|true
-detectorCloneIdiom=CloneIdiom|true
+detectorCloneIdiom=CloneIdiom|false
 detectorComparatorIdiom=ComparatorIdiom|true
 detectorConfusedInheritance=ConfusedInheritance|true
 detectorConfusionBetweenInheritedAndOuterMethod=ConfusionBetweenInheritedAndOuterMethod|true
-- 
1.6.3.rc4.206.g03e16
Previous: Shawn O. PearceNext: Sohn, Matthias
Message 7 of 8 in “Fix FindBugs exclude filter to work on UNIX platforms”
  1. 1/7 Fix FindBugs exclude filter to work on UNIX platformsShawn O. Pearce, May 4, 2009
  2. 2/7 Silence FindBugs "dubious use of GC" in PackFile.mmapShawn O. Pearce, May 4, 2009
  3. 3/7 Fix FindBugs String == is bad formShawn O. Pearce, May 4, 2009
  4. 4/7 Fix FindBugs load known null valueShawn O. Pearce, May 4, 2009
  5. 5/7 FindBugs: Fix use of byte[].toString() in error messagesShawn O. Pearce, May 4, 2009
  6. 6/7 Make TransportLocal.StreamRewritingThread staticShawn O. Pearce, May 4, 2009
  7. 7/7 FindBugs: Disable clone() idiom testsShawn O. Pearce, May 4, 2009
  8. Sohn, MatthiasMay 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.