git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 6/7] Make TransportLocal.StreamRewritingThread static

From
Shawn O. Pearce <spearce@spearce.org>
Date
May 4, 2009, 23:30 UTC
Message-ID
<1241479848-20687-6-git-send-email-spearce@spearce.org>
In-Reply-To
<1241479848-20687-5-git-send-email-spearce@spearce.org>
This thread doesn't need access to the outer instance.
Noticed by FindBugs.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../org/spearce/jgit/transport/TransportLocal.java |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java
index dae8951..cffdba1 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java
@@ -363,7 +363,7 @@ public void close() {
 		}
 	}
 
-	class StreamRewritingThread extends Thread {
+	static class StreamRewritingThread extends Thread {
 		private final InputStream in;
 
 		StreamRewritingThread(final String cmd, final InputStream in) {
-- 
1.6.3.rc4.206.g03e16
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 6 of 8 in “Fix FindBugs exclude filter to work on UNIX platforms”
  1. 1/7 Fix FindBugs exclude filter to work on UNIX platformsShawn O. Pearce, May 4, 2009
  2. 2/7 Silence FindBugs "dubious use of GC" in PackFile.mmapShawn O. Pearce, May 4, 2009
  3. 3/7 Fix FindBugs String == is bad formShawn O. Pearce, May 4, 2009
  4. 4/7 Fix FindBugs load known null valueShawn O. Pearce, May 4, 2009
  5. 5/7 FindBugs: Fix use of byte[].toString() in error messagesShawn O. Pearce, May 4, 2009
  6. 6/7 Make TransportLocal.StreamRewritingThread staticShawn O. Pearce, May 4, 2009
  7. 7/7 FindBugs: Disable clone() idiom testsShawn O. Pearce, May 4, 2009
  8. Sohn, MatthiasMay 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.