[JGIT PATCH 3/7] Fix FindBugs String == is bad form
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- May 4, 2009, 23:30 UTC
- Message-ID
- <1241479848-20687-3-git-send-email-spearce@spearce.org>
- In-Reply-To
- <1241479848-20687-2-git-send-email-spearce@spearce.org>
We only used "a == b" to test for both values == null, as we can't use a.equalsIgnoreCase if a is null. Instead test for that null case, and fall through for everything else.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- .../src/org/spearce/jgit/lib/RepositoryConfig.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java b/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java index 87fc254..cb287ee 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java @@ -1102,7 +1102,7 @@ boolean match(final String aBase, final String aExtendedBase, } private static boolean eq(final String a, final String b) { - if (a == b) + if (a == null && b == null) return true; if (a == null || b == null) return false;
-- 1.6.3.rc4.206.g03e16