git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix git-shell build error when NO_SETENV is defined

From
Stephan Beyer <s-beyer@gmx.net>
Date
Jul 21, 2008, 00:43 UTC
Message-ID
<1216601017-7871-1-git-send-email-s-beyer@gmx.net>
In-Reply-To
<g60la4$diu$1@ger.gmane.org>
If NO_SETENV is defined, git-shell could not be built.
Thanks to SungHyun Nam for the hint.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
This was my mistake. I haven't tested with several build options.
Now I've tested with
	NO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1
	NO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1
and compat/setenv.o seems to be the only one that was missing.
Regards.
 Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 2b670d7..b650ee6 100644
--- a/Makefile
+++ b/Makefile
@@ -1203,7 +1203,8 @@ git-http-push$X: revision.o http.o http-push.o $(GITLIBS)
 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
 		$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)
 
-git-shell$X: compat/strlcpy.o abspath.o ctype.o exec_cmd.o quote.o strbuf.o usage.o wrapper.o shell.o
+git-shell$X: compat/strlcpy.o compat/setenv.o abspath.o ctype.o exec_cmd.o \
+	     quote.o strbuf.o usage.o wrapper.o shell.o
 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^)
 
 $(LIB_OBJS) $(BUILTIN_OBJS): $(LIB_H)
-- 
1.5.6.3.390.g7b30
Previous: SungHyun NamNext: Johannes Schindelin
Message 2 of 5 in “git-shell build error”
  1. SungHyun NamJul 21, 2008
  2. Fix git-shell build error when NO_SETENV is definedStephan Beyer, Jul 21, 2008
  3. Johannes SchindelinJul 21, 2008
  4. Stephan BeyerJul 21, 2008
  5. Johannes SchindelinJul 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.