From: Stephan Beyer Date: Mon, 21 Jul 2008 00:43:37 GMT Subject: [PATCH] Fix git-shell build error when NO_SETENV is defined Message-ID: <1216601017-7871-1-git-send-email-s-beyer@gmx.net> In-Reply-To: If NO_SETENV is defined, git-shell could not be built. Thanks to SungHyun Nam for the hint. Signed-off-by: Stephan Beyer --- This was my mistake. I haven't tested with several build options. Now I've tested with NO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1 NO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1 and compat/setenv.o seems to be the only one that was missing. Regards. Makefile | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 2b670d7..b650ee6 100644 --- a/Makefile +++ b/Makefile @@ -1203,7 +1203,8 @@ git-http-push$X: revision.o http.o http-push.o $(GITLIBS) $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \ $(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT) -git-shell$X: compat/strlcpy.o abspath.o ctype.o exec_cmd.o quote.o strbuf.o usage.o wrapper.o shell.o +git-shell$X: compat/strlcpy.o compat/setenv.o abspath.o ctype.o exec_cmd.o \ + quote.o strbuf.o usage.o wrapper.o shell.o $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIB_OBJS) $(BUILTIN_OBJS): $(LIB_H) -- 1.5.6.3.390.g7b30