git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix git-shell build error when NO_SETENV is defined

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 21, 2008, 01:23 UTC
Message-ID
<alpine.DEB.1.00.0807210321190.3305@eeepc-johanness>
In-Reply-To
<1216601017-7871-1-git-send-email-s-beyer@gmx.net>
Hi,
On Mon, 21 Jul 2008, Stephan Beyer wrote:
Show 12 quoted lines
> If NO_SETENV is defined, git-shell could not be built.
> 
> Thanks to SungHyun Nam for the hint.
> 
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
> ---
> 
> This was my mistake. I haven't tested with several build options.
> Now I've tested with
> 	NO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1
> 	NO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1
> and compat/setenv.o seems to be the only one that was missing.

Funny. It was not 24 hours ago that Hannes reported a related issue. And he was testing with different options.

His fix to include COMPAT_OBJECTS made much more sense, too, than to pick selectively a file here and a file there and then hoping that you catch all.

Ciao, Dscho

Previous: Stephan BeyerNext: Stephan Beyer
Message 3 of 5 in “git-shell build error”
  1. SungHyun NamJul 21, 2008
  2. Fix git-shell build error when NO_SETENV is definedStephan Beyer, Jul 21, 2008
  3. Johannes SchindelinJul 21, 2008
  4. Stephan BeyerJul 21, 2008
  5. Johannes SchindelinJul 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.