git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/12] revision.c: handle tag->tagged == NULL

From
MKMartin Koegler <mkoegler@auto.tuwien.ac.at>
Date
Feb 18, 2008, 20:48 UTC
Message-ID
<12033676841373-git-send-email-mkoegler@auto.tuwien.ac.at>
In-Reply-To
<12033676842301-git-send-email-mkoegler@auto.tuwien.ac.at>
Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
---
 revision.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/revision.c b/revision.c
index 484e5e7..b1aebf8 100644
--- a/revision.c
+++ b/revision.c
@@ -177,6 +177,8 @@ static struct commit *handle_commit(struct rev_info *revs, struct object *object
 		struct tag *tag = (struct tag *) object;
 		if (revs->tag_objects && !(flags & UNINTERESTING))
 			add_pending_object(revs, object, tag->tag);
+		if (!tag->tagged)
+			die("bad tag");
 		object = parse_object(tag->tagged->sha1);
 		if (!object)
 			die("bad object %s", sha1_to_hex(tag->tagged->sha1));
@@ -689,6 +691,8 @@ static int add_parents_only(struct rev_info *revs, const char *arg, int flags)
 		it = get_reference(revs, arg, sha1, 0);
 		if (it->type != OBJ_TAG)
 			break;
+		if (!((struct tag*)it)->tagged)
+			return 0;
 		hashcpy(sha1, ((struct tag*)it)->tagged->sha1);
 	}
 	if (it->type != OBJ_COMMIT)

-- 
1.5.4.1.g96b77
Previous: Martin KoeglerNext: Martin Koegler
Message 10 of 13 in “read_object_with_reference: don't read beyond the buffer”
  1. 01/12 read_object_with_reference: don't read beyond the bufferMartin Koegler, Feb 18, 2008
  2. 02/12 get_sha1_oneline: check return value of parse_objectMartin Koegler, Feb 18, 2008
  3. 03/12 mark_blob/tree_uninteresting: check for NULLMartin Koegler, Feb 18, 2008
  4. 04/12 add_one_tree: handle NULL from lookup_treeMartin Koegler, Feb 18, 2008
  5. 05/12 process_tree/blob: check for NULLMartin Koegler, Feb 18, 2008
  6. 06/12 check results of parse_commit in merge_basesMartin Koegler, Feb 18, 2008
  7. 07/12 peel_onion: handle NULLMartin Koegler, Feb 18, 2008
  8. 08/12 process_tag: handle tag->tagged == NULLMartin Koegler, Feb 18, 2008
  9. 09/12 process_tree/blob: check for NULLMartin Koegler, Feb 18, 2008
  10. 10/12 revision.c: handle tag->tagged == NULLMartin Koegler, Feb 18, 2008
  11. 11/12 parse_commit: don't fail, if object is NULLMartin Koegler, Feb 18, 2008
  12. 12/12 check return value from parse_commitMartin Koegler, Feb 18, 2008
  13. Junio C HamanoFeb 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.