git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 11/12] parse_commit: don't fail, if object is NULL

From
MKMartin Koegler <mkoegler@auto.tuwien.ac.at>
Date
Feb 18, 2008, 20:48 UTC
Message-ID
<12033676841015-git-send-email-mkoegler@auto.tuwien.ac.at>
In-Reply-To
<12033676841373-git-send-email-mkoegler@auto.tuwien.ac.at>

Some codepaths (eg. builtin-rev-parse -> get_merge_bases -> parse_commit) can pass NULL.

Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
---
 commit.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/commit.c b/commit.c
index 70f1266..5d57450 100644
--- a/commit.c
+++ b/commit.c
@@ -311,6 +311,8 @@ int parse_commit(struct commit *item)
 	unsigned long size;
 	int ret;
 
+	if (!item)
+		return -1;
 	if (item->object.parsed)
 		return 0;
 	buffer = read_sha1_file(item->object.sha1, &type, &size);
-- 
1.5.4.1.g96b77
Previous: Martin KoeglerNext: Martin Koegler
Message 11 of 13 in “read_object_with_reference: don't read beyond the buffer”
  1. 01/12 read_object_with_reference: don't read beyond the bufferMartin Koegler, Feb 18, 2008
  2. 02/12 get_sha1_oneline: check return value of parse_objectMartin Koegler, Feb 18, 2008
  3. 03/12 mark_blob/tree_uninteresting: check for NULLMartin Koegler, Feb 18, 2008
  4. 04/12 add_one_tree: handle NULL from lookup_treeMartin Koegler, Feb 18, 2008
  5. 05/12 process_tree/blob: check for NULLMartin Koegler, Feb 18, 2008
  6. 06/12 check results of parse_commit in merge_basesMartin Koegler, Feb 18, 2008
  7. 07/12 peel_onion: handle NULLMartin Koegler, Feb 18, 2008
  8. 08/12 process_tag: handle tag->tagged == NULLMartin Koegler, Feb 18, 2008
  9. 09/12 process_tree/blob: check for NULLMartin Koegler, Feb 18, 2008
  10. 10/12 revision.c: handle tag->tagged == NULLMartin Koegler, Feb 18, 2008
  11. 11/12 parse_commit: don't fail, if object is NULLMartin Koegler, Feb 18, 2008
  12. 12/12 check return value from parse_commitMartin Koegler, Feb 18, 2008
  13. Junio C HamanoFeb 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.