git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 04/12] add_one_tree: handle NULL from lookup_tree

From
MKMartin Koegler <mkoegler@auto.tuwien.ac.at>
Date
Feb 18, 2008, 20:47 UTC
Message-ID
<12033676832653-git-send-email-mkoegler@auto.tuwien.ac.at>
In-Reply-To
<12033676832231-git-send-email-mkoegler@auto.tuwien.ac.at>
Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
---
 reachable.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/reachable.c b/reachable.c
index 823e324..937af57 100644
--- a/reachable.c
+++ b/reachable.c
@@ -150,7 +150,8 @@ static int add_one_reflog(const char *path, const unsigned char *sha1, int flag,
 static void add_one_tree(const unsigned char *sha1, struct rev_info *revs)
 {
 	struct tree *tree = lookup_tree(sha1);
-	add_pending_object(revs, &tree->object, "");
+	if (tree)
+		add_pending_object(revs, &tree->object, "");
 }
 
 static void add_cache_tree(struct cache_tree *it, struct rev_info *revs)

-- 
1.5.4.1.g96b77
Previous: Martin KoeglerNext: Martin Koegler
Message 4 of 13 in “read_object_with_reference: don't read beyond the buffer”
  1. 01/12 read_object_with_reference: don't read beyond the bufferMartin Koegler, Feb 18, 2008
  2. 02/12 get_sha1_oneline: check return value of parse_objectMartin Koegler, Feb 18, 2008
  3. 03/12 mark_blob/tree_uninteresting: check for NULLMartin Koegler, Feb 18, 2008
  4. 04/12 add_one_tree: handle NULL from lookup_treeMartin Koegler, Feb 18, 2008
  5. 05/12 process_tree/blob: check for NULLMartin Koegler, Feb 18, 2008
  6. 06/12 check results of parse_commit in merge_basesMartin Koegler, Feb 18, 2008
  7. 07/12 peel_onion: handle NULLMartin Koegler, Feb 18, 2008
  8. 08/12 process_tag: handle tag->tagged == NULLMartin Koegler, Feb 18, 2008
  9. 09/12 process_tree/blob: check for NULLMartin Koegler, Feb 18, 2008
  10. 10/12 revision.c: handle tag->tagged == NULLMartin Koegler, Feb 18, 2008
  11. 11/12 parse_commit: don't fail, if object is NULLMartin Koegler, Feb 18, 2008
  12. 12/12 check return value from parse_commitMartin Koegler, Feb 18, 2008
  13. Junio C HamanoFeb 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.