git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[REPLACEMENT PATCH 3/6] push: support pushing HEAD to real branch name

From
Steffen Prohaska <prohaska@zib.de>
Date
Nov 11, 2007, 14:35 UTC
Message-ID
<1194791707467-git-send-email-prohaska@zib.de>
In-Reply-To
<47370EDF.3090907@op5.se>

This teaches "push <remote> HEAD" to resolve HEAD on the local side to its real branch name, e.g. master, and then act as if the real branch name was specified. So we have a shorthand for pushing the current branch. Besides HEAD, no other symbolic ref is resolved.

Thanks to Daniel Barkalow <barkalow@iabervon.org> for suggesting this implementation, which is much simpler than the implementation proposed before.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
 builtin-push.c        |    9 +++++++++
 t/t5516-fetch-push.sh |   17 +++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
prefixcmp() is simpler.
    Steffen
diff --git a/builtin-push.c b/builtin-push.c
index 6d1da07..54fba0e 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -44,6 +44,15 @@ static void set_refspecs(const char **refs, int nr)
 			strcat(tag, refs[i]);
 			ref = tag;
 		}
+		if (!strcmp("HEAD", ref)) {
+			unsigned char sha1_dummy[20];
+			ref = resolve_ref(ref, sha1_dummy, 1, NULL);
+			if (!ref)
+				die("HEAD cannot be resolved.");
+			if (prefixcmp(ref, "refs/heads/"))
+				die("HEAD cannot be resolved to branch.");
+			ref = xstrdup(ref + 11);
+		}
 		add_refspec(ref);
 	}
 }
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
index 86f9b53..b0ff488 100755
--- a/t/t5516-fetch-push.sh
+++ b/t/t5516-fetch-push.sh
@@ -244,6 +244,23 @@ test_expect_success 'push with colon-less refspec (4)' '
 
 '
 
+test_expect_success 'push with HEAD' '
+
+	mk_test heads/master &&
+	git checkout master &&
+	git push testrepo HEAD &&
+	check_push_result $the_commit heads/master
+
+'
+
+test_expect_success 'push with HEAD nonexisting at remote' '
+
+	mk_test heads/master &&
+	git checkout -b local master &&
+	git push testrepo HEAD &&
+	check_push_result $the_commit heads/local
+'
+
 test_expect_success 'push with dry-run' '
 
 	mk_test heads/master &&
-- 
1.5.3.5.643.g20245
Previous: Andreas EricssonNext: Steffen Prohaska
Message 15 of 18 in “improve refspec handling in push, refactor matching in fetch”
  1. 0/6 improve refspec handling in push, refactor matching in fetchSteffen Prohaska, Nov 11, 2007
  2. 1/6 push: mention --verbose option in documentationSteffen Prohaska, Nov 11, 2007
  3. 2/6 push: teach push to pass --verbose option to transport layerSteffen Prohaska, Nov 11, 2007
  4. 3/6 push: support pushing HEAD to real branch nameSteffen Prohaska, Nov 11, 2007
  5. 4/6 add ref_abbrev_matches_full_with_rules()Steffen Prohaska, Nov 11, 2007
  6. 5/6 push: use same rules as git-rev-parse to resolve refspecsSteffen Prohaska, Nov 11, 2007
  7. 6/6 refactor fetch's ref matching to use ref_abbrev_matches_full_with_rules()Steffen Prohaska, Nov 11, 2007
  8. Jakub NarebskiNov 11, 2007
  9. Steffen ProhaskaNov 11, 2007
  10. Junio C HamanoNov 12, 2007
  11. Steffen ProhaskaNov 12, 2007
  12. Junio C HamanoNov 12, 2007
  13. Steffen ProhaskaNov 12, 2007
  14. Andreas EricssonNov 11, 2007
  15. 3/6 push: support pushing HEAD to real branch nameSteffen Prohaska, Nov 11, 2007
  16. Steffen ProhaskaNov 11, 2007
  17. Steffen ProhaskaNov 11, 2007
  18. Junio C HamanoNov 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.