git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/6] push: teach push to pass --verbose option to transport layer

From
Steffen Prohaska <prohaska@zib.de>
Date
Nov 11, 2007, 14:01 UTC
Message-ID
<11947897081278-git-send-email-prohaska@zib.de>
In-Reply-To
<11947897083381-git-send-email-prohaska@zib.de>
From: Steffen Prohaska <gitster@pobox.com>

A --verbose option to push should also be passed to the transport layer, i.e. git-send-pack, git-http-push.

git push is modified to do so.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin-push.c |    2 ++
 transport.c    |    8 ++++++--
 transport.h    |    1 +
 3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/builtin-push.c b/builtin-push.c
index 2c56195..6d1da07 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -115,6 +115,8 @@ int cmd_push(int argc, const char **argv, const char *prefix)
 		flags |= TRANSPORT_PUSH_FORCE;
 	if (dry_run)
 		flags |= TRANSPORT_PUSH_DRY_RUN;
+	if (verbose)
+		flags |= TRANSPORT_PUSH_VERBOSE;
 	if (tags)
 		add_refspec("refs/tags/*");
 	if (all)
diff --git a/transport.c b/transport.c
index fa5cfbb..e8a2608 100644
--- a/transport.c
+++ b/transport.c
@@ -386,7 +386,7 @@ static int curl_transport_push(struct transport *transport, int refspec_nr, cons
 	int argc;
 	int err;
 
-	argv = xmalloc((refspec_nr + 11) * sizeof(char *));
+	argv = xmalloc((refspec_nr + 12) * sizeof(char *));
 	argv[0] = "http-push";
 	argc = 1;
 	if (flags & TRANSPORT_PUSH_ALL)
@@ -395,6 +395,8 @@ static int curl_transport_push(struct transport *transport, int refspec_nr, cons
 		argv[argc++] = "--force";
 	if (flags & TRANSPORT_PUSH_DRY_RUN)
 		argv[argc++] = "--dry-run";
+	if (flags & TRANSPORT_PUSH_VERBOSE)
+		argv[argc++] = "--verbose";
 	argv[argc++] = transport->url;
 	while (refspec_nr--)
 		argv[argc++] = *refspec++;
@@ -655,7 +657,7 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const
 	int argc;
 	int err;
 
-	argv = xmalloc((refspec_nr + 11) * sizeof(char *));
+	argv = xmalloc((refspec_nr + 12) * sizeof(char *));
 	argv[0] = "send-pack";
 	argc = 1;
 	if (flags & TRANSPORT_PUSH_ALL)
@@ -664,6 +666,8 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const
 		argv[argc++] = "--force";
 	if (flags & TRANSPORT_PUSH_DRY_RUN)
 		argv[argc++] = "--dry-run";
+	if (flags & TRANSPORT_PUSH_VERBOSE)
+		argv[argc++] = "--verbose";
 	if (data->receivepack) {
 		char *rp = xmalloc(strlen(data->receivepack) + 16);
 		sprintf(rp, "--receive-pack=%s", data->receivepack);
diff --git a/transport.h b/transport.h
index df12ea7..2f80ab4 100644
--- a/transport.h
+++ b/transport.h
@@ -30,6 +30,7 @@ struct transport {
 #define TRANSPORT_PUSH_ALL 1
 #define TRANSPORT_PUSH_FORCE 2
 #define TRANSPORT_PUSH_DRY_RUN 4
+#define TRANSPORT_PUSH_VERBOSE 8
 
 /* Returns a transport suitable for the url */
 struct transport *transport_get(struct remote *, const char *);
-- 
1.5.3.5.578.g886d
Previous: Steffen ProhaskaNext: Steffen Prohaska
Message 3 of 18 in “improve refspec handling in push, refactor matching in fetch”
  1. 0/6 improve refspec handling in push, refactor matching in fetchSteffen Prohaska, Nov 11, 2007
  2. 1/6 push: mention --verbose option in documentationSteffen Prohaska, Nov 11, 2007
  3. 2/6 push: teach push to pass --verbose option to transport layerSteffen Prohaska, Nov 11, 2007
  4. 3/6 push: support pushing HEAD to real branch nameSteffen Prohaska, Nov 11, 2007
  5. 4/6 add ref_abbrev_matches_full_with_rules()Steffen Prohaska, Nov 11, 2007
  6. 5/6 push: use same rules as git-rev-parse to resolve refspecsSteffen Prohaska, Nov 11, 2007
  7. 6/6 refactor fetch's ref matching to use ref_abbrev_matches_full_with_rules()Steffen Prohaska, Nov 11, 2007
  8. Jakub NarebskiNov 11, 2007
  9. Steffen ProhaskaNov 11, 2007
  10. Junio C HamanoNov 12, 2007
  11. Steffen ProhaskaNov 12, 2007
  12. Junio C HamanoNov 12, 2007
  13. Steffen ProhaskaNov 12, 2007
  14. Andreas EricssonNov 11, 2007
  15. 3/6 push: support pushing HEAD to real branch nameSteffen Prohaska, Nov 11, 2007
  16. Steffen ProhaskaNov 11, 2007
  17. Steffen ProhaskaNov 11, 2007
  18. Junio C HamanoNov 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.