git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] reachable.c: Use for_each_revision() helper

From
LCLuiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Date
Apr 27, 2007, 17:00 UTC
Message-ID
<1177693212471-git-send-email-lcapitulino@mandriva.com.br>
In-Reply-To
<11776932123749-git-send-email-lcapitulino@mandriva.com.br>
From: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
---
 reachable.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/reachable.c b/reachable.c
index ff3dd34..b69edd8 100644
--- a/reachable.c
+++ b/reachable.c
@@ -79,7 +79,7 @@ static void walk_commit_list(struct rev_info *revs)
 	struct object_array objects = { 0, 0, NULL };
 
 	/* Walk all commits, process their trees */
-	while ((commit = get_revision(revs)) != NULL)
+	for_each_revision(commit, revs)
 		process_tree(commit->tree, &objects, NULL, "");
 
 	/* Then walk all the pending objects, recursively processing them too */
@@ -195,6 +195,5 @@ void mark_reachable_objects(struct rev_info *revs, int mark_reflog)
 	 * Set up the revision walk - this will move all commits
 	 * from the pending list to the commit walking list.
 	 */
-	prepare_revision_walk(revs);
 	walk_commit_list(revs);
 }
-- 
1.5.1.1.372.g4342
Previous: Luiz Fernando N. CapitulinoNext: Luiz Fernando N. Capitulino
Message 15 of 17 in “New for_each_revision() helper”
  1. 0/5 New for_each_revision() helperLuiz Fernando N. Capitulino, Apr 27, 2007
  2. 1/5 Introduces for_each_revision() helperLuiz Fernando N. Capitulino, Apr 27, 2007
  3. Junio C HamanoApr 27, 2007
  4. Luiz Fernando N. CapitulinoApr 27, 2007
  5. Junio C HamanoApr 29, 2007
  6. Shawn O. PearceApr 29, 2007
  7. Junio C HamanoApr 30, 2007
  8. Johannes SchindelinApr 28, 2007
  9. Alex RiesenApr 28, 2007
  10. Johannes SchindelinApr 28, 2007
  11. Luiz Fernando N. CapitulinoApr 28, 2007
  12. Alex RiesenApr 28, 2007
  13. Luiz Fernando N. CapitulinoApr 29, 2007
  14. 2/5 builtin-fmt-merge-msg.c: Use for_each_revision() helperLuiz Fernando N. Capitulino, Apr 27, 2007
  15. 3/5 reachable.c: Use for_each_revision() helperLuiz Fernando N. Capitulino, Apr 27, 2007
  16. 4/5 builtin-shortlog.c: Use for_each_revision() helperLuiz Fernando N. Capitulino, Apr 27, 2007
  17. 5/5 builtin-log.c: Use for_each_revision() helperLuiz Fernando N. Capitulino, Apr 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.