[PATCH 5/5] builtin-log.c: Use for_each_revision() helper
From: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
---
builtin-log.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 38bf52f..705050a 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -79,8 +79,7 @@ static int cmd_log_walk(struct rev_info *rev)
{
struct commit *commit;
- prepare_revision_walk(rev);
- while ((commit = get_revision(rev)) != NULL) {
+ for_each_revision(commit, rev) {
log_tree_commit(rev, commit);
if (!rev->reflog_info) {
/* we allow cycles in reflog ancestry */
@@ -390,9 +389,8 @@ static void get_patch_ids(struct rev_info *rev, struct patch_ids *ids, const cha
o2->flags ^= UNINTERESTING;
add_pending_object(&check_rev, o1, "o1");
add_pending_object(&check_rev, o2, "o2");
- prepare_revision_walk(&check_rev);
- while ((commit = get_revision(&check_rev)) != NULL) {
+ for_each_revision(commit, &check_rev) {
/* ignore merges */
if (commit->parents && commit->parents->next)
continue;
@@ -578,8 +576,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
if (!use_stdout)
realstdout = fdopen(dup(1), "w");
- prepare_revision_walk(&rev);
- while ((commit = get_revision(&rev)) != NULL) {
+ for_each_revision(commit, &rev) {
/* ignore merges */
if (commit->parents && commit->parents->next)
continue;
@@ -716,8 +713,7 @@ int cmd_cherry(int argc, const char **argv, const char *prefix)
die("Unknown commit %s", limit);
/* reverse the list of commits */
- prepare_revision_walk(&revs);
- while ((commit = get_revision(&revs)) != NULL) {
+ for_each_revision(commit, &revs) {
/* ignore merges */
if (commit->parents && commit->parents->next)
continue;
--
1.5.1.1.372.g4342