git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/7] n is in fact unused, and is later shadowed.

From
Pierre Habouzit <madcoder@debian.org>
Date
Aug 23, 2006, 10:39 UTC
Message-ID
<1156329557613-git-send-email-madcoder@debian.org>
In-Reply-To
<1156329557424-git-send-email-madcoder@debian.org>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 date.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/date.c b/date.c
index 66be23a..63d1d5b 100644
--- a/date.c
+++ b/date.c
@@ -584,10 +584,9 @@ static const char *approxidate_alpha(con
 	const struct typelen *tl;
 	const struct special *s;
 	const char *end = date;
-	int n = 1, i;
+	int i;
 
-	while (isalpha(*++end))
-		n++;
+	while (isalpha(*++end));
 
 	for (i = 0; i < 12; i++) {
 		int match = match_string(date, month_names[i]);
-- 
1.4.1.1
Previous: Pierre Habouzit
Message 7 of 7 in “avoid to use error that shadows the function name, use err instead.”
  1. 1/7 avoid to use error that shadows the function name, use err instead.Pierre Habouzit, Aug 23, 2006
  2. 2/7 git_dir holds pointers to local strings, hence MUST be const.Pierre Habouzit, Aug 23, 2006
  3. 3/7 missing 'static' keywordsPierre Habouzit, Aug 23, 2006
  4. 4/7 remove ugly shadowing of loop indexes in subloops.Pierre Habouzit, Aug 23, 2006
  5. 5/7 missing #define DEBUG 0 that made the preprocessor whinePierre Habouzit, Aug 23, 2006
  6. 6/7 use name[len] in switch directly, instead of creating a shadowed variable.Pierre Habouzit, Aug 23, 2006
  7. 7/7 n is in fact unused, and is later shadowed.Pierre Habouzit, Aug 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.