git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/7] git_dir holds pointers to local strings, hence MUST be const.

From
Pierre Habouzit <madcoder@debian.org>
Date
Aug 23, 2006, 10:39 UTC
Message-ID
<11563295562422-git-send-email-madcoder@debian.org>
In-Reply-To
<11563295562072-git-send-email-madcoder@debian.org>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 cache.h       |    2 +-
 environment.c |    7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/cache.h b/cache.h
index 08d6a91..3044794 100644
--- a/cache.h
+++ b/cache.h
@@ -123,7 +123,7 @@ #define DB_ENVIRONMENT "GIT_OBJECT_DIREC
 #define INDEX_ENVIRONMENT "GIT_INDEX_FILE"
 #define GRAFT_ENVIRONMENT "GIT_GRAFT_FILE"
 
-extern char *get_git_dir(void);
+extern const char *get_git_dir(void);
 extern char *get_object_directory(void);
 extern char *get_refs_directory(void);
 extern char *get_index_file(void);
diff --git a/environment.c b/environment.c
index e6bd003..5fae9ac 100644
--- a/environment.c
+++ b/environment.c
@@ -25,8 +25,9 @@ int zlib_compression_level = Z_DEFAULT_C
 int pager_in_use;
 int pager_use_color = 1;
 
-static char *git_dir, *git_object_dir, *git_index_file, *git_refs_dir,
-	*git_graft_file;
+static const char *git_dir;
+static char *git_object_dir, *git_index_file, *git_refs_dir, *git_graft_file;
+
 static void setup_git_env(void)
 {
 	git_dir = getenv(GIT_DIR_ENVIRONMENT);
@@ -49,7 +50,7 @@ static void setup_git_env(void)
 		git_graft_file = strdup(git_path("info/grafts"));
 }
 
-char *get_git_dir(void)
+const char *get_git_dir(void)
 {
 	if (!git_dir)
 		setup_git_env();
-- 
1.4.1.1
Previous: Pierre HabouzitNext: Pierre Habouzit
Message 2 of 7 in “avoid to use error that shadows the function name, use err instead.”
  1. 1/7 avoid to use error that shadows the function name, use err instead.Pierre Habouzit, Aug 23, 2006
  2. 2/7 git_dir holds pointers to local strings, hence MUST be const.Pierre Habouzit, Aug 23, 2006
  3. 3/7 missing 'static' keywordsPierre Habouzit, Aug 23, 2006
  4. 4/7 remove ugly shadowing of loop indexes in subloops.Pierre Habouzit, Aug 23, 2006
  5. 5/7 missing #define DEBUG 0 that made the preprocessor whinePierre Habouzit, Aug 23, 2006
  6. 6/7 use name[len] in switch directly, instead of creating a shadowed variable.Pierre Habouzit, Aug 23, 2006
  7. 7/7 n is in fact unused, and is later shadowed.Pierre Habouzit, Aug 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.