git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/7] avoid to use error that shadows the function name, use err instead.

From
Pierre Habouzit <madcoder@debian.org>
Date
Aug 23, 2006, 10:39 UTC
Message-ID
<11563295562072-git-send-email-madcoder@debian.org>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 builtin-apply.c |    6 +++---
 builtin-push.c  |   10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/builtin-apply.c b/builtin-apply.c
index 4f0eef0..5991737 100644
--- a/builtin-apply.c
+++ b/builtin-apply.c
@@ -1907,13 +1907,13 @@ static int check_patch(struct patch *pat
 static int check_patch_list(struct patch *patch)
 {
 	struct patch *prev_patch = NULL;
-	int error = 0;
+	int err = 0;
 
 	for (prev_patch = NULL; patch ; patch = patch->next) {
-		error |= check_patch(patch, prev_patch);
+		err |= check_patch(patch, prev_patch);
 		prev_patch = patch;
 	}
-	return error;
+	return err;
 }
 
 static void show_index_list(struct patch *list)
diff --git a/builtin-push.c b/builtin-push.c
index 2b5e6fa..ada8338 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -232,7 +232,7 @@ static int do_push(const char *repo)
 	common_argc = argc;
 
 	for (i = 0; i < n; i++) {
-		int error;
+		int err;
 		int dest_argc = common_argc;
 		int dest_refspec_nr = refspec_nr;
 		const char **dest_refspec = refspec;
@@ -248,10 +248,10 @@ static int do_push(const char *repo)
 		while (dest_refspec_nr--)
 			argv[dest_argc++] = *dest_refspec++;
 		argv[dest_argc] = NULL;
-		error = run_command_v(argc, argv);
-		if (!error)
+		err = run_command_v(argc, argv);
+		if (!err)
 			continue;
-		switch (error) {
+		switch (err) {
 		case -ERR_RUN_COMMAND_FORK:
 			die("unable to fork for %s", sender);
 		case -ERR_RUN_COMMAND_EXEC:
@@ -262,7 +262,7 @@ static int do_push(const char *repo)
 		case -ERR_RUN_COMMAND_WAITPID_NOEXIT:
 			die("%s died with strange error", sender);
 		default:
-			return -error;
+			return -err;
 		}
 	}
 	return 0;
-- 
1.4.1.1
Next: Pierre Habouzit
Message 1 of 7 in “avoid to use error that shadows the function name, use err instead.”
  1. 1/7 avoid to use error that shadows the function name, use err instead.Pierre Habouzit, Aug 23, 2006
  2. 2/7 git_dir holds pointers to local strings, hence MUST be const.Pierre Habouzit, Aug 23, 2006
  3. 3/7 missing 'static' keywordsPierre Habouzit, Aug 23, 2006
  4. 4/7 remove ugly shadowing of loop indexes in subloops.Pierre Habouzit, Aug 23, 2006
  5. 5/7 missing #define DEBUG 0 that made the preprocessor whinePierre Habouzit, Aug 23, 2006
  6. 6/7 use name[len] in switch directly, instead of creating a shadowed variable.Pierre Habouzit, Aug 23, 2006
  7. 7/7 n is in fact unused, and is later shadowed.Pierre Habouzit, Aug 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.