git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Collecting cvsps patches

From
PRPavel Roskin <proski@gnu.org>
Date
Jun 15, 2006, 03:08 UTC
Message-ID
<1150340912.24184.7.camel@dv>
In-Reply-To
<200606150921.34690.lan@academsoft.ru>
On Thu, 2006-06-15 at 09:21 +0700, Alexander Litvinov wrote:
> Your master branch is not compilable. This is the fix for it.

Actually, revision 5ecebc5064df0fd578dbf4b5ba5255e9af8cda7a renamed "tagnames" to "link" in cvsps_types.h, so I think the same should be done in cache.c.

Also, you can check the definition of list_entry, you'll see that the member (argument 3) is cast to the pointer to the requested type (argument 2). I don't think it's safe to cast name to a pointer to TagName.

That said, having non-compilable repository defeats the purpose of collecting the patches to cvsps. Shouldn't only compilable patches be allowed in the repository?

-- 
Regards,
Pavel Roskin
Previous: Alexander LitvinovNext: Alexander Litvinov
Message 18 of 21 in “Collecting cvsps patches”
  1. Yann DirsonJun 11, 2006
  2. Pavel RoskinJun 13, 2006
  3. Yann DirsonJun 13, 2006
  4. David MansfieldJun 13, 2006
  5. Yann DirsonJun 13, 2006
  6. Pavel RoskinJun 13, 2006
  7. Linus TorvaldsJun 13, 2006
  8. Yann DirsonJun 16, 2006
  9. Jakub NarebskiJun 13, 2006
  10. What's in cvsps.gitYann Dirson, Jun 16, 2006
  11. Yann DirsonJun 11, 2006
  12. Anand KumriaJun 12, 2006
  13. Yann DirsonJun 16, 2006
  14. Jakub NarebskiJun 16, 2006
  15. Junio C HamanoJun 16, 2006
  16. Junio C HamanoJun 17, 2006
  17. Alexander LitvinovJun 15, 2006
  18. Pavel RoskinJun 15, 2006
  19. Alexander LitvinovJun 15, 2006
  20. Yann DirsonJun 15, 2006
  21. Yann DirsonJun 15, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.