From: Pavel Roskin Date: Thu, 15 Jun 2006 03:08:32 GMT Subject: Re: Collecting cvsps patches Message-ID: <1150340912.24184.7.camel@dv> In-Reply-To: <200606150921.34690.lan@academsoft.ru> On Thu, 2006-06-15 at 09:21 +0700, Alexander Litvinov wrote: > Your master branch is not compilable. This is the fix for it. Actually, revision 5ecebc5064df0fd578dbf4b5ba5255e9af8cda7a renamed "tagnames" to "link" in cvsps_types.h, so I think the same should be done in cache.c. Also, you can check the definition of list_entry, you'll see that the member (argument 3) is cast to the pointer to the requested type (argument 2). I don't think it's safe to cast name to a pointer to TagName. That said, having non-compilable repository defeats the purpose of collecting the patches to cvsps. Shouldn't only compilable patches be allowed in the repository? -- Regards, Pavel Roskin