Re: Collecting cvsps patches
- From
- Alexander Litvinov <lan@academsoft.ru>
- Date
- Jun 15, 2006, 03:14 UTC
- Message-ID
- <200606151014.31716.lan@academsoft.ru>
- In-Reply-To
- <1150340912.24184.7.camel@dv>
Show 8 quoted lines
> Actually, revision 5ecebc5064df0fd578dbf4b5ba5255e9af8cda7a renamed > "tagnames" to "link" in cvsps_types.h, so I think the same should be > done in cache.c. > > Also, you can check the definition of list_entry, you'll see that the > member (argument 3) is cast to the pointer to the requested type > (argument 2). I don't think it's safe to cast name to a pointer to > TagName.
You are right. My patch is wrong. I have tried to import real cvs repo and cvsps broke with sigsegv.