git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [patch] fixup GECOS handling

From
David Woodhouse <dwmw2@infradead.org>
Date
Apr 18, 2005, 12:35 UTC
Message-ID
<1113827713.5286.13.camel@localhost.localdomain>
In-Reply-To
<1113820589.16288.5.camel@nosferatu.lan>
On Mon, 2005-04-18 at 12:36 +0200, Martin Schlemmer wrote:
> realgecos[strchr(realgecos, ',') - realgecos] = '\0';

Er, *strchr(realgecos, ',') = 0; surely? Even if the compiler is clever enough to optimise out the gratuitous addition and subtraction, that's no real excuse for it.

-- 
dwmw2
Previous: Martin SchlemmerNext: Martin Schlemmer
Message 2 of 16 in “fixup GECOS handling”
  1. fixup GECOS handlingMartin Schlemmer, Apr 18, 2005
  2. David WoodhouseApr 18, 2005
  3. Martin SchlemmerApr 18, 2005
  4. fixup GECOS handlingMartin Schlemmer, Apr 22, 2005
  5. Kyle HayesApr 22, 2005
  6. Martin SchlemmerApr 22, 2005
  7. Petr BaudisApr 22, 2005
  8. Martin SchlemmerApr 22, 2005
  9. Kyle HayesApr 22, 2005
  10. Martin SchlemmerApr 22, 2005
  11. Kyle HayesApr 22, 2005
  12. Petr BaudisApr 23, 2005
  13. Martin SchlemmerApr 23, 2005
  14. Kyle HayesApr 22, 2005
  15. Andy IsaacsonApr 22, 2005
  16. Kyle HayesApr 25, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.