Re: [patch] fixup GECOS handling

From: Kyle Hayes <kyle@marchex.com>
Date: Apr 25, 2005, 17:02 UTC
Message-ID: <1114448538.13449.14.camel@axer.marchex.com>
In-Reply-To: <20050422233012.GA27638@hexapodia.org>

On Fri, 2005-04-22 at 16:30 -0700, Andy Isaacson wrote:

Show 17 quoted lines

> On Fri, Apr 22, 2005 at 09:16:39AM -0700, Kyle Hayes wrote:
> > if(comma)
> > 	if(semi)
> > 		/* lastname, firstname; room #; phone # format */
> > 		*semi  = 0;
> > 	else
> > 		*comma = 0;
> > else if(semi)
> > 	*semi = 0;
> 
> That's a really complicated way of writing
> 
> if(semi) *semi = 0;
> else if(comma) *comma = 0;
> 
> (The two code fragments are precisely identical.  Mmmm, strength
> reduction.)

Indeed :-)

As someone else noted, this was too complex. As another person noted, this (like the SHA1 thread) has been thrashed around more than enough.

Best, Kyle

-- 
Kyle Hayes <kyle@marchex.com>
Marchex Inc.