From: David Woodhouse Date: Mon, 18 Apr 2005 12:35:12 GMT Subject: Re: [patch] fixup GECOS handling Message-ID: <1113827713.5286.13.camel@localhost.localdomain> In-Reply-To: <1113820589.16288.5.camel@nosferatu.lan> On Mon, 2005-04-18 at 12:36 +0200, Martin Schlemmer wrote: > realgecos[strchr(realgecos, ',') - realgecos] = '\0'; Er, *strchr(realgecos, ',') = 0; surely? Even if the compiler is clever enough to optimise out the gratuitous addition and subtraction, that's no real excuse for it. -- dwmw2