git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Nov 3, 2017, 13:37 UTC
Message-ID
<0dd48f07-6174-1a4e-c1f0-bae5b18cebd1@jeffhostetler.com>
In-Reply-To
<alpine.DEB.2.21.1.1711031254280.6482@virtualbox>
On 11/3/2017 7:54 AM, Johannes Schindelin wrote:
Show 14 quoted lines
> Hi Jonathan,
> 
> On Thu, 2 Nov 2017, Jonathan Tan wrote:
> 
>> On Thu,  2 Nov 2017 17:50:11 +0000
>> Jeff Hostetler <git@jeffhostetler.com> wrote:
>>
>>> +int parse_list_objects_filter(struct list_objects_filter_options *filter_options,
>>> +			      const char *arg)
>>
>> Returning void is fine, I think. It seems that all your code paths
>> either return 0 or die.
> 
> Can we please start to encourage libified code, rather than discourage it?

I did that so that I could call it from the opt_parse_... version below it that is used by the OPT_ macros.

And Johannes is right, it bothers me that there doesn't seem to be a hard line where one should or should not call die() vs returning an error code.

Jeff
Previous: Johannes SchindelinNext: Jeff Hostetler
Message 7 of 20 in “Partial clone part 1: object filtering”
  1. 0/6 Partial clone part 1: object filteringJeff Hostetler, Nov 2, 2017
  2. 1/6 dir: allow exclusions from blob in addition to fileJeff Hostetler, Nov 2, 2017
  3. 2/6 oidmap: add oidmap iterator methodsJeff Hostetler, Nov 2, 2017
  4. 4/6 list-objects: filter objects in traverse_commit_listJeff Hostetler, Nov 2, 2017
  5. Jonathan TanNov 2, 2017
  6. Johannes SchindelinNov 3, 2017
  7. Jeff HostetlerNov 3, 2017
  8. Jeff HostetlerNov 7, 2017
  9. Jeff HostetlerNov 6, 2017
  10. Jonathan TanNov 6, 2017
  11. 6/6 pack-objects: add list-objects filteringJeff Hostetler, Nov 2, 2017
  12. 5/6 rev-list: add list-objects filtering supportJeff Hostetler, Nov 2, 2017
  13. 3/6 oidset: add iterator methods to oidsetJeff Hostetler, Nov 2, 2017
  14. Jonathan TanNov 2, 2017
  15. Jeff HostetlerNov 3, 2017
  16. Junio C HamanoNov 3, 2017
  17. Jeff HostetlerNov 3, 2017
  18. Jonathan TanNov 8, 2017
  19. Junio C HamanoNov 8, 2017
  20. Jeff HostetlerNov 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.