From: Jeff Hostetler <git@jeffhostetler.com>
Date: Fri, 03 Nov 2017 13:37:43 GMT
Subject: Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list
Message-ID: <0dd48f07-6174-1a4e-c1f0-bae5b18cebd1@jeffhostetler.com>
In-Reply-To: <alpine.DEB.2.21.1.1711031254280.6482@virtualbox>



On 11/3/2017 7:54 AM, Johannes Schindelin wrote:
> Hi Jonathan,
> 
> On Thu, 2 Nov 2017, Jonathan Tan wrote:
> 
>> On Thu,  2 Nov 2017 17:50:11 +0000
>> Jeff Hostetler <git@jeffhostetler.com> wrote:
>>
>>> +int parse_list_objects_filter(struct list_objects_filter_options *filter_options,
>>> +			      const char *arg)
>>
>> Returning void is fine, I think. It seems that all your code paths
>> either return 0 or die.
> 
> Can we please start to encourage libified code, rather than discourage it?


I did that so that I could call it from the opt_parse_... version below
it that is used by the OPT_ macros.

And Johannes is right, it bothers me that there doesn't seem to be a hard
line where one should or should not call die() vs returning an error code.

Jeff