git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Nov 3, 2017, 18:34 UTC
Message-ID
<97585434-6d57-dad4-d7aa-e48dacec1b3f@jeffhostetler.com>
In-Reply-To
<xmqq7ev7pfln.fsf@gitster.mtv.corp.google.com>
On 11/3/2017 11:05 AM, Junio C Hamano wrote:
Show 11 quoted lines
> Jeff Hostetler <git@jeffhostetler.com> writes:
> 
>> Yes, I thought we should have both (perhaps renamed or combined
>> into 1 parameter with value, such as --exclude=missing vs --exclude=promisor)
>> and let the user decide how strict they want to be.
> 
> Assuming we eventually get promisor support working, would there be
> any use case where "any missing is OK" mode would be useful in a
> sense more reasonable than "because we could have such a mode" and
> "it is not our business to prevent users from playing with fire"?
>

For now, I'd like to keep my "any missing is OK" option. I do think it has value all by itself.

We are essentially using something like that now with our GVFS users on the gigantic Windows repo and haven't had any issues.

But yes, when we get promisor support working, we could revisit the need for this parameter.

However, I do have some scaling concerns here. If for example, I have 100M missing blobs (because we did an only commits-and-trees clone), the cost to compute "promisor missing" vs "just missing" might be prohibitively expensive. It could be something we want fsck/gc to be aware of, but other commands may want to just assume any missing objects are expected and continue.

Hopefully, we won't have a scale problem, but we just don't know yet.

Jeff
Previous: Junio C HamanoNext: Jonathan Tan
Message 17 of 20 in “Partial clone part 1: object filtering”
  1. 0/6 Partial clone part 1: object filteringJeff Hostetler, Nov 2, 2017
  2. 1/6 dir: allow exclusions from blob in addition to fileJeff Hostetler, Nov 2, 2017
  3. 2/6 oidmap: add oidmap iterator methodsJeff Hostetler, Nov 2, 2017
  4. 4/6 list-objects: filter objects in traverse_commit_listJeff Hostetler, Nov 2, 2017
  5. Jonathan TanNov 2, 2017
  6. Johannes SchindelinNov 3, 2017
  7. Jeff HostetlerNov 3, 2017
  8. Jeff HostetlerNov 7, 2017
  9. Jeff HostetlerNov 6, 2017
  10. Jonathan TanNov 6, 2017
  11. 6/6 pack-objects: add list-objects filteringJeff Hostetler, Nov 2, 2017
  12. 5/6 rev-list: add list-objects filtering supportJeff Hostetler, Nov 2, 2017
  13. 3/6 oidset: add iterator methods to oidsetJeff Hostetler, Nov 2, 2017
  14. Jonathan TanNov 2, 2017
  15. Jeff HostetlerNov 3, 2017
  16. Junio C HamanoNov 3, 2017
  17. Jeff HostetlerNov 3, 2017
  18. Jonathan TanNov 8, 2017
  19. Junio C HamanoNov 8, 2017
  20. Jeff HostetlerNov 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.