Re: [PATCH bw/realpath-wo-chdir] real_path: canonicalize directory separators in root parts
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Dec 22, 2016, 06:07 UTC
- Message-ID
- <0c9aa347-d64e-b7d7-9b07-52d844d76252@kdbg.org>
- In-Reply-To
- <20161221223304.GA119874@google.com>
Am 21.12.2016 um 23:33 schrieb Brandon Williams:
Show 14 quoted lines
> On 12/21, Johannes Sixt wrote:
>> +/* copies root part from remaining to resolved, canonicalizing it on the way */
>> +static void get_root_part(struct strbuf *resolved, struct strbuf *remaining)
>> +{
>> + int offset = offset_1st_component(remaining->buf);
>> +
>> + strbuf_reset(resolved);
>> + strbuf_add(resolved, remaining->buf, offset);
>> +#ifdef GIT_WINDOWS_NATIVE
>> + convert_slashes(resolved->buf);
>> +#endif
>
> So then the only extra cononicalization that is happening here is
> converting '\\server\share' to '//server/share'? (or 'c:\' to 'c:/')Correct. All other directory separators are canonicalized by the primary function, strbuf_realpath.
-- Hannes