git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] add--interactive: quote commentChar regex

From
CRChristian Rösch <christian@croesch.de>
Date
Jun 21, 2017, 21:12 UTC
Message-ID
<0bd23975-2283-fb98-c685-9adc0a9f0216@croesch.de>
In-Reply-To
<20170621192859.udejhkl66ylsbg24@sigill.intra.peff.net>
Thanks for the quick reaction and fix!
On 21/06/17 21:28, Jeff King wrote:
> If your chosen comment character is a regex metacharacter,
> then that will behave in a confusing manner ("$", for
> instance, would only eliminate blank lines, not actual
> comment lines).

So things would get worse when using * as comment char?! Maybe I should consider a more uncommon character as comment char ;)

Best wishes, Christian

Previous: Jeff King
Message 6 of 6 in “git add -p does not work with custom comment char currently”
  1. Christian RöschJun 21, 2017
  2. Jeff KingJun 21, 2017
  3. 0/2 Re: git add -p does not work with custom comment char currentlyJeff King, Jun 21, 2017
  4. 1/2 add--interactive: handle EOF in prompt_yesnoJeff King, Jun 21, 2017
  5. 2/2 add--interactive: quote commentChar regexJeff King, Jun 21, 2017
  6. Christian RöschJun 21, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.