[PATCH 0/2] Re: git add -p does not work with custom comment char currently

From: Jeff King <peff@peff.net>
Date: Jun 21, 2017, 19:23 UTC
Message-ID: <20170621192315.3umx4lszvzwjffnb@sigill.intra.peff.net>
In-Reply-To: <20170621182020.ywopkykzdfhlxi5o@sigill.intra.peff.net>

On Wed, Jun 21, 2017 at 02:20:21PM -0400, Jeff King wrote:

Show 10 quoted lines

> I can reproduce easily here with the script below. It looks like a
> regression in c9d961647 (i18n: add--interactive: mark edit_hunk_manually
> message for translation, 2016-12-14), which is in v2.12.0. It taught the
> script to write out with the comment char, but reading it back does not
> seem to work.
>
> [...]
>
> I think there's another bug, too, where the "patch did not apply
> cleanly" prompt goes into an infinite loop if it gets EOF.

Here are fixes for both.

  [1/2]: add--interactive: handle EOF in prompt_yesno
  [2/2]: add--interactive: quote commentChar regex

 git-add--interactive.perl  | 3 ++-
 t/t3701-add-interactive.sh | 8 ++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

-Peff