From: Christian Rösch Date: Wed, 21 Jun 2017 21:12:56 GMT Subject: Re: [PATCH 2/2] add--interactive: quote commentChar regex Message-ID: <0bd23975-2283-fb98-c685-9adc0a9f0216@croesch.de> In-Reply-To: <20170621192859.udejhkl66ylsbg24@sigill.intra.peff.net> Thanks for the quick reaction and fix! On 21/06/17 21:28, Jeff King wrote: > If your chosen comment character is a regex metacharacter, > then that will behave in a confusing manner ("$", for > instance, would only eliminate blank lines, not actual > comment lines). So things would get worse when using * as comment char?! Maybe I should consider a more uncommon character as comment char ;) Best wishes, Christian