git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional

From
René Scharfe <l.s.r@web.de>
Date
Sep 24, 2017, 12:39 UTC
Message-ID
<047033a6-1e3d-103e-a406-cc89447f4327@web.de>
In-Reply-To
<xmqq60c8j38t.fsf@gitster.mtv.corp.google.com>
Am 24.09.2017 um 03:26 schrieb Junio C Hamano:
> I wonder if we want a dedicated helper for them (perhaps about a
> dozen callers we have that fall into this pattern?) to call for the
> exact purpose, implemented as a thin-wrapper around the
> resolve_ref_unsafe() function, though.
refs_resolve_ref_unsafe() effectively has seven wrappers already:
	resolve_ref_unsafe()
	refs_resolve_refdup()
	resolve_refdup()
	refs_read_ref_full()
	read_ref_full()
	read_ref()
	ref_exists()

The last one already supplies a dummy SHA1 buffer; for a handful of the others we could add and use variants that do the same. I feel that this API would become a bit crowded, though.

René
Previous: Junio C HamanoNext: René Scharfe
Message 5 of 8 in “refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional”
  1. 1/3 refs: make sha1 output parameter of refs_resolve_ref_unsafe() optionalRené Scharfe, Sep 23, 2017
  2. 2/3 refs: pass NULL to refs_resolve_ref_unsafe() if hash is not neededRené Scharfe, Sep 23, 2017
  3. 3/3 refs: pass NULL to resolve_ref_unsafe() if hash is not neededRené Scharfe, Sep 23, 2017
  4. Junio C HamanoSep 24, 2017
  5. René ScharfeSep 24, 2017
  6. 4/3 refs: pass NULL to refs_resolve_refdup() if hash is not neededRené Scharfe, Oct 1, 2017
  7. 5/3 refs: pass NULL to resolve_refdup() if hash is not neededRené Scharfe, Oct 1, 2017
  8. Junio C HamanoOct 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.