From: René Scharfe <l.s.r@web.de>
Date: Sun, 24 Sep 2017 12:39:40 GMT
Subject: Re: [PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional
Message-ID: <047033a6-1e3d-103e-a406-cc89447f4327@web.de>
In-Reply-To: <xmqq60c8j38t.fsf@gitster.mtv.corp.google.com>

Am 24.09.2017 um 03:26 schrieb Junio C Hamano:
> I wonder if we want a dedicated helper for them (perhaps about a
> dozen callers we have that fall into this pattern?) to call for the
> exact purpose, implemented as a thin-wrapper around the
> resolve_ref_unsafe() function, though.

refs_resolve_ref_unsafe() effectively has seven wrappers already:

	resolve_ref_unsafe()
	refs_resolve_refdup()
	resolve_refdup()
	refs_read_ref_full()
	read_ref_full()
	read_ref()

	ref_exists()

The last one already supplies a dummy SHA1 buffer; for a handful of
the others we could add and use variants that do the same.  I feel
that this API would become a bit crowded, though.

René